Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BO - Affichage mode album] Améliorations UI #2439

Closed
4 tasks
mathildepoulpux opened this issue Apr 9, 2024 · 2 comments
Closed
4 tasks

[BO - Affichage mode album] Améliorations UI #2439

mathildepoulpux opened this issue Apr 9, 2024 · 2 comments
Assignees
@hmeneuvrier
Labels
Accessibilité Concerne un problème d'accessibilité Amélioration Pas une nouveauté ni un bug mais une amélioration de l'existant Espace documentaire v2.2.0
Projects
Backlog 🪵
Milestone
v2.2.0

Comments

@mathildepoulpux
Copy link
Collaborator

Pour des raisons d'usage et d'accessibilité, il y a des améliorations UI à faire sur le mode album

image

  • Ajouter une marge sous la photo, avant la description
  • Augmenter l'espace entre la description et l'auteur de la photo
  • Ajouter l'icône fr-icon-close-line dans le bouton "Fermer"
  • Modifier la couleur des boutons (accessibilité) : il faut utiliser les boutons du thème "sombre" dans le DSFR

image
@mathildepoulpux mathildepoulpux added Amélioration Pas une nouveauté ni un bug mais une amélioration de l'existant Accessibilité Concerne un problème d'accessibilité Espace documentaire labels Apr 9, 2024
@mathildepoulpux mathildepoulpux added this to 🟢 Dans le sprint - To do in Backlog 🪵 Apr 9, 2024
@hmeneuvrier hmeneuvrier moved this from 🟢 Dans le sprint - To do to 💻 Sprint - Doing in Backlog 🪵 Apr 11, 2024
@hmeneuvrier hmeneuvrier self-assigned this Apr 11, 2024
hmeneuvrier added a commit that referenced this issue Apr 11, 2024
@hmeneuvrier
fix on UI album photo #2439
a318c93
@hmeneuvrier hmeneuvrier mentioned this issue Apr 11, 2024
Merged
1 task
@hmeneuvrier hmeneuvrier moved this from 💻 Sprint - Doing to ⚠️ Sprint - Code revue in Backlog 🪵 Apr 11, 2024
hmeneuvrier added a commit that referenced this issue Apr 16, 2024
@hmeneuvrier
fix on UI album photo #2439
a0bb906
hmeneuvrier added a commit that referenced this issue Apr 16, 2024
@hmeneuvrier
switch to thme dark en photo album #2439
3e28d92
@hmeneuvrier hmeneuvrier moved this from ⚠️ Sprint - Code revue to 🔍 Sprint - Tests in Backlog 🪵 Apr 16, 2024
Backlog 🪵 automation moved this from 🔍 Sprint - Tests to ✅ Done Apr 19, 2024
@mathildepoulpux
Copy link
Collaborator Author

Je rouvre ce ticket : c'était bon sur la review app début de semaine dernière mais là c'est plus bon ni sur staging ni sur la reviex app 🤷‍♀️

@mathildepoulpux mathildepoulpux moved this from ✅ Done to 🟢 Dans le sprint - To do in Backlog 🪵 Apr 22, 2024
@numew numew moved this from 🟢 Dans le sprint - To do to 💻 Sprint - Doing in Backlog 🪵 Apr 22, 2024
@numew numew moved this from 💻 Sprint - Doing to 🟢 Dans le sprint - To do in Backlog 🪵 Apr 22, 2024
@sfinx13 sfinx13 moved this from 🟢 Dans le sprint - To do to 🔍 Sprint - Tests in Backlog 🪵 Apr 23, 2024
@hmeneuvrier hmeneuvrier moved this from 🔍 Sprint - Tests to 💻 Sprint - Doing in Backlog 🪵 Apr 24, 2024
@hmeneuvrier
Copy link
Collaborator

hmeneuvrier commented Apr 24, 2024 •
edited
Loading

@mathildepoulpux c'est curieux, ça ne marche pas à la première ouverture de l'album photo, mais ça marche aux ouvertures suivantes, je regarde

et en local évidemment cela fonctionne nickel...

hmeneuvrier added a commit that referenced this issue Apr 24, 2024
@hmeneuvrier
fix switch theme #2439
115b4c8
@hmeneuvrier hmeneuvrier mentioned this issue Apr 24, 2024
Merged
1 task
hmeneuvrier added a commit that referenced this issue Apr 24, 2024
@hmeneuvrier
fix siwtch dark theme #2439
af6ed67
@hmeneuvrier hmeneuvrier mentioned this issue Apr 24, 2024
Merged
1 task
@hmeneuvrier hmeneuvrier moved this from 💻 Sprint - Doing to ⚠️ Sprint - Code revue in Backlog 🪵 Apr 24, 2024
@hmeneuvrier hmeneuvrier moved this from ⚠️ Sprint - Code revue to 🔍 Sprint - Tests in Backlog 🪵 Apr 25, 2024
@sfinx13 sfinx13 added the v2.2.0 label May 7, 2024
@sfinx13 sfinx13 closed this as completed May 7, 2024
Backlog 🪵 automation moved this from 🔍 Sprint - Tests to ✅ Done May 7, 2024
@mathildepoulpux mathildepoulpux added this to the v2.2.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmeneuvrier hmeneuvrier

Labels
Accessibilité Concerne un problème d'accessibilité Amélioration Pas une nouveauté ni un bug mais une amélioration de l'existant Espace documentaire v2.2.0
Projects
Produit Histologe 🏡
Status: En prod
Backlog 🪵
✅ Done
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@sfinx13 @hmeneuvrier @mathildepoulpux