Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BO - Affichage mode album] Améliorations UI #2460

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[BO - Affichage mode album] Améliorations UI #2460

merged 2 commits into from
Apr 16, 2024

Conversation

hmeneuvrier
Copy link
Collaborator

Ticket

#2439

Description

  • Ajouter une marge sous la photo, avant la description
  • Augmenter l'espace entre la description et l'auteur de la photo
  • Ajouter l'icône fr-icon-close-line dans le bouton "Fermer"
  • Modifier la couleur des boutons (accessibilité) : il faut utiliser les boutons du thème "sombre" dans le DSFR (je n'ai pas réussi à activier le passage en mode sombre en js, ni à utiliser les variables, mais en utilisant les codes rgb c'est ok, ouvert à amélioration)

Changements apportés

  • css et txig

Pré-requis

Tests

  • Afficher l'album et vérifier l'UI

emilschn
emilschn requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un com css, pas encore testé

assets/styles/histologe.scss Outdated Show resolved Hide resolved
numew
numew approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@numew numew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'accord avec le com d’Émilien, tests ok, j'approuve quand même

@hmeneuvrier hmeneuvrier force-pushed the bugfix/2439-bo-affichage-mode-album-ui branch from a318c93 to a0bb906 Compare April 16, 2024 10:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

emilschn
emilschn approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK comme ça :)

@emilschn emilschn merged commit c070dcc into develop Apr 16, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the bugfix/2439-bo-affichage-mode-album-ui branch April 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@numew numew numew approved these changes

@sfinx13 sfinx13 Awaiting requested review from sfinx13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hmeneuvrier @emilschn @numew