Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front] Activer ou désactiver l'affichage nouveau formulaire #2157

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Jan 30, 2024

Ticket

#1559

Description

Le nouveau formulaire et le formulaire actuel doivent partager la même route afin de pas perturber les usagers et partenaires.
L'activation du nouveau formulaire doit rendre inactif le formulaire actuel et vice-versa

Changements apportés

Pré-requis

Tests

  • Désactiver la variable d'environnement FEATURE_NEW_FORM_ENABLE=0 le nouveau formulaire ne doit plus être accessible
  • Test de soumission formulaire actuel http://localhost:8080/signalement
  • Activer la variable d'environnement FEATURE_NEW_FORM_ENABLE=1
  • Test de soumission du nouveau formulaire http://localhost:8080/signalement
  • Importer et tester la collection postman (nouveau et ancien formulaire)

return $this->render('front/nouveau_formulaire.html.twig', [
'uuid_signalement' => null,
]);
return $this->redirectToRoute('front_signalement');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les tests ont déjà commencé, je laisse donc la route, cette route sera supprimé après la MEP du nouveau formulaire

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sfinx13
Copy link
Collaborator Author

sfinx13 commented Jan 30, 2024

Sur les tests la variable d'environnement reste false, je laisse comme ça (ça continue de tester la soumission de l'ancien et du nouveau formulaire)

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests et relecture OK

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests et relecture OK

@hmeneuvrier hmeneuvrier merged commit af2a260 into develop Jan 30, 2024
3 checks passed
@sfinx13 sfinx13 deleted the feature/1559-enable-disable-new-form branch February 13, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants