Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front] Activer ou désactiver l'affichage nouveau formulaire #2157

Merged
merged 3 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/Controller/FrontNewSignalementController.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,19 @@
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Validator\Validator\ValidatorInterface;

#[Route('/nouveau-formulaire')]
class FrontNewSignalementController extends AbstractController
{
#[Route('/signalement', name: 'front_nouveau_formulaire')]
#[Route('/nouveau-formulaire/signalement', name: 'front_nouveau_formulaire')]
public function index(ParameterBagInterface $parameterBag): Response
{
if (!$parameterBag->get('feature_new_form')) {
return $this->redirectToRoute('front_signalement');
}

return $this->render('front/nouveau_formulaire.html.twig', [
'uuid_signalement' => null,
]);
return $this->redirectToRoute('front_signalement');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les tests ont déjà commencé, je laisse donc la route, cette route sera supprimé après la MEP du nouveau formulaire

}

#[Route('/signalement/{uuid}', name: 'front_nouveau_formulaire_edit')]
#[Route('/signalement-draft/{uuid}', name: 'front_nouveau_formulaire_edit', methods: 'GET')]
public function edit(
SignalementDraft $signalementDraft,
ParameterBagInterface $parameterBag
): Response {
// TODO : sécurité ?

if (!$parameterBag->get('feature_new_form')) {
return $this->redirectToRoute('front_signalement');
}
Expand Down
54 changes: 46 additions & 8 deletions src/Controller/FrontSignalementController.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
use Exception;
use Psr\Log\LoggerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\DependencyInjection\Attribute\Autowire;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
Expand All @@ -52,8 +53,18 @@
class FrontSignalementController extends AbstractController
{
#[Route('/signalement', name: 'front_signalement')]
public function index(SituationRepository $situationRepository, Request $request): Response
{
public function index(
SituationRepository $situationRepository,
Request $request,
#[Autowire(env: 'FEATURE_NEW_FORM_ENABLE')]
bool $enableNewFormFeature,
): Response {
if ($enableNewFormFeature) {
return $this->render('front/nouveau_formulaire.html.twig', [
'uuid_signalement' => null,
]);
}

$title = 'Signalez vos problèmes de logement';
$etats = ['Etat moyen', 'Mauvais état', 'Très mauvais état'];
$etats_classes = ['moyen', 'grave', 'tres-grave'];
Expand All @@ -72,18 +83,28 @@ public function index(SituationRepository $situationRepository, Request $request
}

#[Route('/checkterritory', name: 'front_signalement_check_territory', methods: ['GET'])]
public function checkTerritory(Request $request, PostalCodeHomeChecker $postalCodeHomeChecker, CommuneRepository $communeRepository): Response
{
public function checkTerritory(
Request $request,
PostalCodeHomeChecker $postalCodeHomeChecker,
CommuneRepository $communeRepository
): Response {
$postalCode = $request->get('cp');
if (empty($postalCode)) {
return $this->json(['success' => false, 'message' => 'Le paramètre "cp" est manquant', 'label' => 'Erreur']);
return $this->json([
'success' => false,
'message' => 'Le paramètre "cp" est manquant',
'label' => 'Erreur',
]);
}

$inseeCode = $request->get('insee');
if (!empty($inseeCode)) {
$commune = $communeRepository->findOneBy(['codePostal' => $postalCode, 'codeInsee' => $inseeCode]);
if (!$commune) {
return $this->json(['success' => false, 'message' => 'Le paramètre code postal et le code insee ne sont pas cohérent', 'label' => 'Erreur']);
return $this->json([
'success' => false,
'message' => 'Le paramètre code postal et le code insee ne sont pas cohérent',
'label' => 'Erreur', ]);
}
}
if ($postalCodeHomeChecker->isActive($postalCode, $inseeCode)) {
Expand Down Expand Up @@ -118,7 +139,9 @@ public function handleUpload(
try {
foreach ($files as $key => $file) {
$res = $uploadHandlerService->toTempFolder($file)->setKey($key);
if (!isset($res['error']) && \in_array($file->getMimeType(), ImageManipulationHandler::IMAGE_MIME_TYPES)) {
if (!isset($res['error'])
&& \in_array($file->getMimeType(), ImageManipulationHandler::IMAGE_MIME_TYPES)
) {
$imageManipulationHandler->resize($res['filePath'])->thumbnail();
}

Expand All @@ -137,6 +160,9 @@ public function handleUpload(

/**
* @throws Exception
*
* @deprecated Cette route est obsolète, elle est remplacée par les routes du
* @see \App\Controller\FrontNewSignalementController
*/
#[Route('/signalement/envoi', name: 'envoi_signalement', methods: 'POST')]
public function envoi(
Expand All @@ -158,9 +184,21 @@ public function envoi(
LoggerInterface $logger,
DocumentProvider $documentProvider,
AutoAssigner $autoAssigner,
#[Autowire(env: 'FEATURE_NEW_FORM_ENABLE')]
bool $enableNewFormFeature,
): Response {
if ($enableNewFormFeature) {
$logger->error(
'La soumission de l\'ancien formulaire est inactif.',
['payload' => $request->request->all()]
);

return $this->json(['response' => 'error'], Response::HTTP_BAD_REQUEST);
}

if ($this->isCsrfTokenValid('new_signalement', $request->request->get('_token'))
&& $data = $request->get('signalement')) {
&& $data = $request->get('signalement')
) {
$signalement = new Signalement();
$dataDateBail = $dataHasDPE = $dataDateDPE = $dataConsoSizeYear = $dataConsoSize = $dataConsoYear = null;
$listNDECriticites = [];
Expand Down
2 changes: 1 addition & 1 deletion templates/front/nouveau_formulaire.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{% block body %}
<div class="fr-my-5v">
<div id="app-signalement-form"
data-ajaxurl="{{ path('front_nouveau_formulaire') }}"
data-ajaxurl="{{ path('front_signalement') }}"
data-ajaxurl-dictionary="{{ path('api_dictionary') }}"
data-ajaxurl-questions="{{ path('api_question_profile') }}?profil="
data-ajaxurl-desordres="{{ path('api_desordres_profile') }}?profil="
Expand Down
Loading
Loading