Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FO] Recevoir / récupérer le lien vers la page de suivi par mail #2325

Merged
merged 12 commits into from
Mar 21, 2024
Merged

[FO] Recevoir / récupérer le lien vers la page de suivi par mail #2325

merged 12 commits into from
Mar 21, 2024

Conversation

numew
Copy link
Collaborator

@numew numew commented Mar 7, 2024 •
edited by hmeneuvrier
Loading

Ticket

#2124

Description

Modification de la home page afin d'y ajouter un CTA "Demande de lien de suivi" Maquette homepage avec CTA
Modification de la page de contact Maquette page de contact

Pré-requis

make npm-build
make composer

Tests

  • Tester le formulaire de demande de lien de suivi sur la homepage
  • Tester le formulaire de demande de lien de suivi sur la page de contact
  • Tester le formulaire de contact

@numew numew marked this pull request as ready for review March 8, 2024 09:45
hmeneuvrier
hmeneuvrier reviewed Mar 11, 2024
View reviewed changes
templates/front/contact.html.twig Show resolved Hide resolved
templates/front/contact.html.twig Show resolved Hide resolved
templates/front/contact.html.twig Show resolved Hide resolved
templates/_partials/_demande-lien-signalement-ok.html.twig Show resolved Hide resolved
src/Repository/SignalementRepository.php Show resolved Hide resolved
src/Repository/SignalementRepository.php Show resolved Hide resolved
src/Form/DemandeLienSignalementType.php Outdated Show resolved Hide resolved
src/Form/ContactType.php Show resolved Hide resolved
src/Form/ContactType.php Outdated Show resolved Hide resolved
@numew numew force-pushed the feature/2124-retrouver-lien-suivi branch from cc2aced to b0533c7 Compare March 11, 2024 13:02
hmeneuvrier
hmeneuvrier approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests et relecture OK

emilschn
emilschn reviewed Mar 11, 2024
View reviewed changes
src/Form/ContactType.php Outdated Show resolved Hide resolved
emilschn
emilschn reviewed Mar 11, 2024
View reviewed changes
src/Form/ContactType.php Outdated Show resolved Hide resolved
emilschn
emilschn requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas encore testé. Quelques retours :)

@numew numew force-pushed the feature/2124-retrouver-lien-suivi branch from 19c4573 to 040d2ee Compare March 12, 2024 13:21
@numew numew mentioned this pull request Mar 12, 2024
Merged
10 tasks
emilschn
emilschn requested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nouveaux petits retours de code.
J'ai rouvert 2 conversations aussi :) (désolé !)

Retour de test : sur la page Contact, si je clique sur le bouton d'envoi, les champs se mettent en rouge mais il n'y a aucun message d'erreur. Idem si je mets une adresse mail non-conforme.

En dehors de ça, mes tests sont fonctionnels.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

@numew
Copy link
Collaborator Author

numew commented Mar 19, 2024

2 nouveaux petits retours de code. J'ai rouvert 2 conversations aussi :) (désolé !)

Retour de test : sur la page Contact, si je clique sur le bouton d'envoi, les champs se mettent en rouge mais il n'y a aucun message d'erreur. Idem si je mets une adresse mail non-conforme.

En dehors de ça, mes tests sont fonctionnels.

Les différents points sont corrigé (j'ai supprimé la validation JS qui apporte moins d'information que celle par défaut du navigateur)

emilschn
emilschn approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et tests ok ! :)

@emilschn emilschn merged commit f700650 into develop Mar 21, 2024
3 checks passed
@numew numew mentioned this pull request Mar 25, 2024
Merged
1 task
@hmeneuvrier hmeneuvrier deleted the feature/2124-retrouver-lien-suivi branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfinx13 sfinx13 sfinx13 left review comments

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@mathildepoulpux mathildepoulpux mathildepoulpux left review comments

@emilschn emilschn emilschn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@numew @emilschn @sfinx13 @hmeneuvrier @mathildepoulpux