-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech] Migre le Frontend de CRA vers Vite #1150
Conversation
ce994a0
to
94da0d9
Compare
1416295
to
8fd8a02
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9429425 | Triggered | Generic Password | 07c4d6b | infra/.env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
62c611c
to
518d26d
Compare
…cision" This reverts commit 1b3b1c6.
8d698ca
to
e95e75b
Compare
## Linked issues - MTES-MCT/monitorenv#1150 ---- - [ ] Tests E2E (Cypress)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done !!! 👏
- FRONTEND_GEOSERVER_NAMESPACE=monitorenv | ||
- FRONTEND_GEOSERVER_REMOTE_URL=http://0.0.0.0:8081 | ||
- FRONTEND_MISSION_FORM_AUTO_SAVE_ENABLED=true | ||
- FRONTEND_MISSION_FORM_AUTO_UPDATE=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est ce qu'on a encore besoin de ça, vu que c'est dans le .env.example
? plutot d'avis de retirer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien vu ! Pour le Docker de test je suis d'accord que ça ne sert pas à grand chose lorsque ce sont les mêmes valeurs.
infra/docker/app/Dockerfile
Outdated
COPY --from=buildFront /tmp/infra/docker/app/env.sh /home/monitorenv/ | ||
COPY --from=buildFront /tmp/frontend/.env.example /home/monitorenv/ | ||
RUN cp /home/monitorenv/.env.example /home/monitorenv/.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
à quoi sert ce .env
dans l'image du coup ? à passer des valeurs par défault ? ou est ce qu'il n'est jamais appelé?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien vu aussi ! Mais alors il faut q'uon fasse un choix : soit on passe toutes les envs par le docker-compose, soit on les passe en copiant le .env
. Le plus propre et conventionnel étant le docker-compose à priori.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plutot partant pour docker compose aussi. Comme ça c'est très clair que le .env
du front sert uniquement en dev
3aae79a
to
0ef64ad
Compare
0ef64ad
to
a7d26f5
Compare
Taches effectuées
/frontend/.env.example
(
/frontend/.env
).import-meta-env
, comme sur MonitorFish. Voir l'ADR correspondant.isPuppeteer()
pour différencier les conditions que l'on applique pour les tests Puppeteer de celles qu'on applique aux tests Cypress. Même principe qu'avecisCypress()
.CONTRIBUTING.md
.npm run cypress:open
parnpm run test:e2e:open
.frontend/src/features/missions/MissionForm/sse.ts
dans un fichier séparé pour éviter un import cycle.Je me suis aussi permis de désactiver un des tests des points d'întérêt parce qu'on est à près de 10% de failure, il y a au moins 4 bugs notables connus sur cette feature et Adeline a prévu de la revoir entièrement.Notes
fontend/.env.example
.cy.fill()
lorsqu'on passera à une der versions Rsuite>5.45.0
qui casse la structure DOM des fields en assignant l'attributid
au wrapper (div
) au lieu de le passer à l'input. Cet attribut est ciblé par attributsfor
des labels. Je ferai le fix.clickOutside()
manquants ou qui ne ferment pas correctement certains dropdowns. À investiguer ?Review
FRONTEND_MISSION_FORM_AUTO_SAVE_ENABLED
dans le docker compose de prod, c'est normal @louptheron ? Rien de problématique mais juste pour être sûr.Related Pull Requests & Issues