Fix build system issues #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I accidentally pushed the fix for libswresample (see #808) on the same branch. I can create a separate PR if required. |
|
That's right, two separate pull requests will be better. Btw, #258 addresses builds on ARM, but having an explicit "no-msse" flag is a good option too. |
This makes sense when building for other platforms than x86.
Martchus
force-pushed
the
fix-build-system
branch
from
06b7146
to
1accb0f
Compare
|
Created a 2nd PR.
It seems so. But it should work the other way around and only add those flags for architectures known to support them. I suppose the check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes to build the library on the Raspberry Pi. The build system picks my CXX_FLAGS nicely. However, it also adds some unwanted ones.
Instead of adding more "clever" detections to decide when to use which flags this change just adds the possibility to skip unwanted ones. That's simple and sufficient.