Add support for setting preset mode and mapping work_state to hvac_action
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_action` Depends on a new version of pydanfossally being released with these changes merged: MTrab/pydanfossally#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now finally possible due to an update to the Danfoss Ally API (that I just happened to come across – would be great to have some release notes or something from their side, but alas).
The API now returns a lot more properties per device in the response, but of course these are mostly undocumented.
I played around with my own setup and discovered that
work_stateapparently maps nicely to HA'shvac_action, so I implemented this. Also, setting preset mode now finally works, so I also included this.Depends on a new version of pydanfossally being released with these changes merged: MTrab/pydanfossally#2
Fixes #16