WIP: Cypress tests #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
force-pushed
the
master
branch
from
f117f86
to
3de077b
Compare
henrixapp
commented
Sep 17, 2020
| with(:sort, search_params[:types]) unless search_params[:types].empty? | ||
| with(:teacher_id, search_params[:teacher_ids]) unless search_params[:teacher_ids].empty? | ||
| with(:program_ids, search_params[:program_ids]) unless search_params[:program_ids].empty? | ||
| with(:term_id, search_params[:term_ids]) unless search_params[:term_ids].empty? |
There was a problem hiding this comment.
Don't know why, but I needed this to get the search working
Adding unless clauses and try to work, when there is no active term.
+ Courses add trait with_tags * Notions: Use different titles, because otherwise validation fails * User: add locale to factory.
1. Create Lecture 2. Create Module 3. Subscribe to Module
henrixapp
commented
Sep 20, 2020
|
|
|
closed in favor of #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate to weppacker some tests have to be written, to check, whether all pages are working.
Current state: Adding three basic test examples by cypress.
Following areas should be covered by tests:
Furthermore needed: