Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign Tiglou mermaid - graphviz branch #865

Merged
merged 9 commits into from
Oct 11, 2017
Merged

Conversation

loopingz
Copy link
Contributor

@loopingz loopingz commented Oct 4, 2017

And add LICENCE and Credits as requested

Closes #625.

@uranusjr
Copy link
Member

Since there’s no response from @tinglou I’ll just go ahead and merge this. Thanks everyone for sticking around! Testing release coming up.

@uranusjr uranusjr merged commit bf3a11c into MacDownApp:master Oct 11, 2017
@legoming
Copy link

legoming commented Apr 2, 2018

is there any test version with mermaid support?

@uranusjr
Copy link
Member

uranusjr commented Apr 7, 2018

@legoming I released one yesterday. You should get it if you turned on auto updates (and opted in for prereleases).

@legoming
Copy link

legoming commented Apr 9, 2018

Update detected, thanks a lot.

@legoming
Copy link

legoming commented Apr 9, 2018

There're two issues during my testing:

  1. flow chart repeated twice
  2. app frozen easily during edit

@FranklinYu
Copy link
Member

@legoming Please provide Minimal Working Example for us to reproduce the two issues.

@loopingz
Copy link
Contributor Author

loopingz commented Apr 9, 2018

I reproduce the repeat, I will check on my side

@loopingz
Copy link
Contributor Author

loopingz commented Apr 9, 2018

I have the fix ready will push another PR with the issue

@legoming
Copy link

For issue2, it happened when I copy paste some new participants, or if I input participant in wrong format, such as in Chinese by mistaken @FranklinYu

    sequenceDiagram
        title: [Figure: LockPatternUtils.resetKeyStore]
        participant LockPatternUtils
        participant LockSettingsService
        participant KeyStore.java
        participant KeyStoreService.cpp
        participant KeyStore.cpp
        LockPatternUtils->>LockSettingsService: resetKeyStore
        loop  Profiles under this User
            LockSettingsService->> LockSettingsService: Unlock managed profile with unified lock
        end
        
        loop Profiles under this User
            loop Uid in SYSTEM_CREDENTIAL_UIDS
                Note over LockSettingsService, KeyStoreService.cpp: WIFI_UID || VPN_UID || ROOT_UID || SYSTEM_UID
                LockSettingsService->> KeyStore.java: clearUid
                KeyStore.java ->>KeyStoreService.cpp: clear_uid
            end
        end
Loading

@loopingz
Copy link
Contributor Author

I am able to reproduce with the Chinese caracters, it might be a limitation from Mermaid but i don't think there is much we can do.

@legoming
Copy link

Got it. Thanks.

@tempelmann
Copy link

tempelmann commented May 2, 2018

Huh, I just installed the latest update (0.7.2d137, with Copyright 2014–2016), and it doesn't seem to support mermaid - and the Help does not mention it, either. What am I missing here?

Huh, looked at the merged "demo.md" that says:

To enable these features, options Mermaid and/or Graphviz in MacDown -> Perferences... -> Rendering should be checked.

However, the app does not offer these options.

Yet, the update dialog mentioned the "flow chart repeated twice" bug fix, so I'd think this version should have this feature implemented, right?

@uranusjr
Copy link
Member

uranusjr commented May 2, 2018

I just made a new release today and might have messed something up. Will investigate.

@inevity
Copy link

inevity commented Dec 18, 2018

Version 0.7.2d167 (1037) of master on macos 10.14 build ok.

This was referenced Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants