-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realign Tiglou mermaid - graphviz branch #865
Conversation
Since there’s no response from @tinglou I’ll just go ahead and merge this. Thanks everyone for sticking around! Testing release coming up. |
is there any test version with mermaid support? |
@legoming I released one yesterday. You should get it if you turned on auto updates (and opted in for prereleases). |
Update detected, thanks a lot. |
There're two issues during my testing:
|
@legoming Please provide Minimal Working Example for us to reproduce the two issues. |
I reproduce the repeat, I will check on my side |
I have the fix ready will push another PR with the issue |
For issue2, it happened when I copy paste some new participants, or if I input participant in wrong format, such as in Chinese by mistaken @FranklinYu sequenceDiagram
title: [Figure: LockPatternUtils.resetKeyStore]
participant LockPatternUtils
participant LockSettingsService
participant KeyStore.java
participant KeyStoreService.cpp
participant KeyStore.cpp
LockPatternUtils->>LockSettingsService: resetKeyStore
loop Profiles under this User
LockSettingsService->> LockSettingsService: Unlock managed profile with unified lock
end
loop Profiles under this User
loop Uid in SYSTEM_CREDENTIAL_UIDS
Note over LockSettingsService, KeyStoreService.cpp: WIFI_UID || VPN_UID || ROOT_UID || SYSTEM_UID
LockSettingsService->> KeyStore.java: clearUid
KeyStore.java ->>KeyStoreService.cpp: clear_uid
end
end
|
I am able to reproduce with the Chinese caracters, it might be a limitation from Mermaid but i don't think there is much we can do. |
Got it. Thanks. |
Huh, I just installed the latest update (0.7.2d137, with Copyright 2014–2016), and it doesn't seem to support mermaid - and the Help does not mention it, either. What am I missing here? Huh, looked at the merged "demo.md" that says:
However, the app does not offer these options. Yet, the update dialog mentioned the "flow chart repeated twice" bug fix, so I'd think this version should have this feature implemented, right? |
I just made a new release today and might have messed something up. Will investigate. |
Version 0.7.2d167 (1037) of master on macos 10.14 build ok. |
And add LICENCE and Credits as requested
Closes #625.