x-macdown URL scheme implementation #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 1, 2018 15:29
Open a file from a browser with url of the form "x-macdown://open?url=file:///path/to/a/file&line=123&column=45" FIXME: Could not figure out how to place the insertion point at a given line and column.
Open a file from a browser with url of the form "x-macdown://open?url=file:///path/to/a/file&line=123&column=45" FIXME: Could not figure out how to place the insertion point at a given line and column.
…l_scheme # Conflicts: # MacDown/Code/Application/MPMainController.m
|
The implementation looks good to me. Could you add some line breaks so the lines don’t get too long? We generally try to keep lines under 80 characters long (not a hard rule, but please try). Thanks so much! |
|
Added some line breaks to try to keep lines under 80 characters long. Best regards. |
|
There’s no built-in way to do this AFAIK, so you probably need to parse the URL yourself and tap into NSTextView API to move the cursor yourself. I’ll merge this as-is because everything works already. We can add the auto-jump feature separately. |
uranusjr
approved these changes
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open a file from a browser with url of the form "x-macdown://open?url=file:///path/to/a/file&line=123&column=45"
FIXME: Could not figure out how to place the insertion point at a given line and column.