Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global autotype: no match #864

Open
k-wax opened this issue Dec 28, 2018 · 14 comments
Open

Global autotype: no match #864

k-wax opened this issue Dec 28, 2018 · 14 comments

Comments

@k-wax
Copy link

k-wax commented Dec 28, 2018

Global autotype works inconsistently

to reproduce
Open database
open safari and a website with saved credentials in the db
press autotype hotkey

Expected behavior
username & password are autotyped and user is logged in

What happens
"No match for ..." error is displayed

Desktop (please complete the following information):

  • macOS: [e.g. 10.14.1]
  • Version [e.g. 0.7.3]

Additional context
Everything in integration tab is checked except for the entry tags checkbox

I got autotype to work with github by replacing "github.com" with "github" in the entry title

right at this moment nothing happens on firefox when pressing the hotkey to autotype github credentials. will reboot now to see if it helps. edit: reboot fixed this one.

example entry:

title: this.domain.org
username: user
password: *****
url: https://this.domain.org/

nothing else
autotype ON

"no match" error given

remove checkbox for "entry title", still no match
also remove checkbox for "entry url" -> no autotype and no error given
re-check "entry url" checkbox -> no autotype and no error given
re-check "entry title" checkbox -> no autotype and no error given

Quitting macpass and opening it again solves this behaviour so it seems that I need to do that between any changes to settings. Still no match though!

IIRC Macpass worked as expected in the very beginnig for a while but then suddenly started to misbehave. My loose assumption is that changing settings somehow breaks autotype functionality.

This also happens on the latest continuous release

@k-wax k-wax changed the title Globa autotype: no match Global autotype: no match Dec 28, 2018
@georgesnow
Copy link
Contributor

Global auto type mataches on window name not url. And depends which options you have selected in the preferences. I had the most luck using tags. And check that option off in preferences and add tag to the entry of “Github”

@mstarke
Copy link
Member

mstarke commented Dec 29, 2018

You're running 0.7.3 which contains some issues with adopting changes to autotype settings without a re-launch. Can you test your setup with the continuous release and see if the issue persists?

@mstarke
Copy link
Member

mstarke commented Dec 29, 2018

@georgesnow I would not encourage using tags. Simply using good titles works since it's a contains search - if the title is contained in the window title, it's a match. The real problem are sites that simply do not put anything special in the title e.g. "Login" instead of "YourSite - Login" which then tends to break auto-type. You might want to add window associations for those pages but then you end up with a bunch of candidates for "Login" if more than one pages doesn't do it properly.

@georgesnow
Copy link
Contributor

@mstarke understood. I will refrain from encouraging others. I had noticed that with some websites what you are saying, which is how i ended up using tags.

However, I will say for my situation I found tags worked better in almost all cases (I use it for applications like iTerm, MS Remote desktop). I could use the same tag across different logins and tags were easy to attach to an entry whereas window assc required some up lift. and if i used multiple tags i could more easily narrow the parameters to get a close match or higher in the list. I would say it's not easy to get to work at first and it took some figuring out, but now it's a way simpler process and management when I add new entries now.

@mstarke
Copy link
Member

mstarke commented Dec 29, 2018

I wasn't aiming to say you should stop suggesting it, but I did not have the need for tags. You seem to have developed a good method to get reliable auto-typ matches so this is worth sharing in case others might run into the same problems and find you way reliable. Tags aren't treated very well in MacPass so this is an area for improvements.

@LeaveAirykson
Copy link

i started to use tags too for that purpose. Because almost half of the sites we use at work have dynamic or bad page titles.

Just out of curiosity without judging: for what reason does macpass not check the url but only the page title?

@mstarke
Copy link
Member

mstarke commented Jan 22, 2019

Just out of curiosity without judging: for what reason does macpass not check the url but only the page title?

Sorry for taking so much time to reply. Autotype is a generic system that uses only the window title of any window to find a match. There is no special handling for browser windows to read the URL as well.

This make autotype work with nearly every application without the need for custom handling. The downside is that no other data supplied by the app apart from the window title will get ignored.

@georgesnow
Copy link
Contributor

I did discover with AppleScript you can grab the front most url and I created an auto fill script
(it’s still crude but so far works well and I use shuttle to trigger it from the menu bar. Also one caveat it has a lot permission triggers with apps etc to be aware of)

Can you use Apple script in Xcode apps like macpass?

——
My script
Open webpage need un and pw
Cursor in UN click shuttle select auto fill script
grabs the url
slice it using / as delimiter.

Then capture that string ex.
https://github.com/MacPass/

Return value “github.com”

Activate macpass past in search
Press enter to move focus top match
Grab username and password (clear clipboard
Bring safari forward so the cursor is in the right place
Auto fill user name and password
And clear variables in Apple script to protect password

@mstarke
Copy link
Member

mstarke commented Mar 25, 2019

Apple Script Support is something I wanted to add in the future but never came to. The simples way would be to allow for querying entries and then using them to fill forms.

@LeaveAirykson
Copy link

LeaveAirykson commented Mar 25, 2019

This make autotype work with nearly every application without the need for custom handling. The downside is that no other data supplied by the app apart from the window title will get ignored.

@mstarke ah ok i understand, thanks for the explanation!

@georgesnow
Copy link
Contributor

well, AppleScript support would be cool! I would love to see it added!

it would greatly simplify my current script and better handle querying Macpass. i can actually get a better match. It can handle multipage logins as well. Basicly it prompts to wait to fill the PW. However, webpages with multiple entries that match means will just fill the first match in the search results. (and if i sat there test every entry it would take to long to fill making it pointless)
I was also working on a AppleScript that would also Autofill other info - Name, Address, CC#, CVC, etc..

on the same vein is anyone interested in my autofill AppleScript? if there is some interest i would consider putting it on GitHub. it just needs just a little more refinement and QA testing.

@georgesnow
Copy link
Contributor

@k-wax check out issue #952

there is a plugin for safari for better matching on URL

@georgesnow
Copy link
Contributor

let me clarify that...plugin for MacPass that helps global autotype to match URLs in Safari

@fipsingdale
Copy link

if using Firefox or Chrome, simply install one of these extensions: https://github.com/MacPass/MacPass/wiki/Autotype#improve-matching-with-a-browser-extension and enable URL matching in MacPass. works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants