Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched from chrome to safari and global auto type never gets website right #952

Open
zeltak opened this issue Jul 12, 2019 · 21 comments
Open

Comments

@zeltak
Copy link

zeltak commented Jul 12, 2019

Describe the bug
switched from chrome to safari and global auto type never gets website right

To Reproduce
Steps to reproduce the behavior:

  1. Go to any site
  2. try to use global auto type
  3. sometimes there is 100% no id and sometimes a choose window appear with wrong entires

Expected behavior
in chrome everything worked well so expected same behaviour

Screenshots
image

Desktop (please complete the following information):

  • macOS: mojave
  • Version 0.7.9 (21570)

Additional context
Add any other context about the problem here.

@georgesnow
Copy link
Contributor

You must have something in the entry that matches. What Are you matching on ? Tags title etc...
There is beta macpass plugin that will match on safari urls which would help provide better matches

@mstarke
Copy link
Member

mstarke commented Jul 12, 2019

What type of matches do you have enabled in the integration preferences? If you want to know what window-title MacPass has extracted, simply open an empty database with MacPass and run gobla autotype. It will show you a notification that it did not find any match to the window title.

I will update the candidate window to show the window title to make this more obvious in the future.

It might be that you did have chrome vent the URL into the title field and Safari doesn't do this so this could explain your bad matches.

@zeltak
Copy link
Author

zeltak commented Jul 13, 2019

Hi!

I enabled all

image

@georgesnow, where can I find that beta plugin?

thx guys

Z

@georgesnow
Copy link
Contributor

https://github.com/MacPass/AutotypeURL

2 caveats
1-You have to build it locally on your machine - page explains how to do that
2- it only matches on sub.domain.com
Eg https://hi.this.com/blah will match on hi.this.com

I am still working on getting GUI preferences set up for allow for full matches

@zeltak
Copy link
Author

zeltak commented Jul 14, 2019

thx @georgesnow

really appreciate it :) building from source both maccpass and the plugin is over my pay grade lol :)

will wait until there is a binary

thx looter again

Z

@zeltak zeltak closed this as completed Jul 14, 2019
@georgesnow
Copy link
Contributor

@zeltak are you using the continuous build version of MacPass? I believe it supports the plugin is that right @mstarke ?

I can build a copy and post it to my forked version page. Maybe tonight or tomorrow. I will post back here.

@mstarke
Copy link
Member

mstarke commented Jul 14, 2019

@zeltak could you please try global Autotype with a newly created database and no entries? This way you can see the window title that MacPass has extracted from Safari. This should be the first step to identify what’s not working in your setup.

@zeltak
Copy link
Author

zeltak commented Jul 15, 2019

Hi @mstarke

I did try new database and the same issue happens. Maybe I'm missing something but apart from not finding the site where do I see the the window title that MacPass has extracted from Safari?

thx

Z

@mstarke
Copy link
Member

mstarke commented Jul 15, 2019

MacPass has to be able to send notifications. If you use a empty database you will see a notification after you have pressed the global autotype hot-key like this one (Which is used on this browser window in Safari):
Screenshot 2019-07-15 at 14 37 11.

The text after "No match for …" is the window title.

A good hint is the Tab name that Safari is displaying. Safari will use this as the window title and MacPass will read this not the URL. Your example has "Login" as window title and the list of candidates all include login somewhere.

As a side note. The integration settings on what to match apply to the Entry not the application window. MacPass will only get the window title, there is no way to retrieve the URL without said plugin from @georgesnow. If you e.g. check the URL box, MacPass will try to find a match of the window title in the URL field of an Entry, not the URL of the browser window!

Chrome might vent the URL in the window title and thus make your matches work better.

@mstarke mstarke reopened this Jul 15, 2019
@georgesnow
Copy link
Contributor

@zeltak here is the compiled beta version. let me know if it works for you and any issues. (as noted it is beta version)

https://github.com/georgesnow/AutotypeURL/releases/tag/BETA

@georgesnow
Copy link
Contributor

@zeltak did you give the plugin a try? I am curious about your experience and if it worked for you as expected.

@mstarke
Copy link
Member

mstarke commented Aug 5, 2019

@zeltak any updates on how this went for you?

@georgesnow
Copy link
Contributor

@zeltak i added a signed version to the release page

@alphaman64
Copy link

I've had a similar problem, and the AutoTypeURL plugin did the trick for me. So far, I've found zero issues (where soFar=time.minutes(5)).

@zeltak
Copy link
Author

zeltak commented Aug 9, 2019

thx @gurgeous
sorry for the late response, im moving countries for work so super busy :)
will try it ASAP and let you know soon!

Z

@alphaman64
Copy link

I've updated to v1.0 of the AutoTypeURL plugin and it's absolutely brilliant. Thanks for making this, it does a great job of detecting the correct logins, and I've got well over 1,000 records between a couple databases open simultaneously.

Nice one!

@mstarke
Copy link
Member

mstarke commented Aug 30, 2019

FWIW I did push the Autotype plugin to the plugin repo and released a 1.0 but currently this requires either MacPass continous. Support for those kinds of plugins will be available with 0.7.10 which should get released rather soon. Currently I'm wrapping up localisations to make this a more "multi-cultural" release :)

@mstarke
Copy link
Member

mstarke commented Aug 30, 2019

and credit where credit's due since this is mostly the idea of @georgesnow and I merely made the code a tiny bit prettier.

@alphaman64
Copy link

That's odd, I'm running 0.7.9 (21570) and have AutoTypeURL running... I did have continuous up until yesterday, when I was looking at the pretty new website update and discovered the 1.0 plugin. Tried it at work and it looked good, so I tried it at home, too, and was successful.

@mstarke
Copy link
Member

mstarke commented Aug 30, 2019

@alphaman64 you might see the plugin being loaded (if you enable force load incompatible plugins) but the plugin will never be called since the code to call it was introduced in f9b3617 which is not present in 0.7.9

@alphaman64
Copy link

Ah, that explains the discrepancy in performance between my 2 systems. Thanks for clarifying that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants