Fix SPM for Tuist #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency in Tuist.
anton-barkov
approved these changes
May 3, 2023
|
Thanks. I've checked it on a project with Tuist and it works. Also verified through standard SPM flow and it works too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When adding this framework as an SPM dependency for Tuist, Tuist doesn't generate
SWIFTPM_MODULE_BUNDLEfor the Objc SPM package.There is a link to related issues in Tuist tuist/tuist#3785 and tuist/tuist#4902.
So, to fix this problem I added the
SWIFTPM_MODULE_BUNDLEimplementation toFMPBundleHelper. That implementation is based on the swift-generated implementation in the fileTuistBundle+FMPFeedbackForm.swift.