Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies.swift][SPM] Use of undeclared identifier 'SWIFTPM_MODULE_BUNDLE' #3785

Closed
PSKuznetsov opened this issue Dec 3, 2021 · 6 comments · Fixed by #5945
Closed

[Dependencies.swift][SPM] Use of undeclared identifier 'SWIFTPM_MODULE_BUNDLE' #3785

PSKuznetsov opened this issue Dec 3, 2021 · 6 comments · Fixed by #5945
Assignees
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:enhancement New feature or request

Comments

@PSKuznetsov
Copy link

Describe the bug
When using ObjC dependency shipped via SPM you will get "Use of undeclared identifier 'SWIFTPM_MODULE_BUNDLE'" if there are Bundle Resources

To Reproduce
Steps to reproduce the behavior:

  1. Download test app
    TestApp.zip

  2. Make tuist dependencies fetch

  3. Try to build the project

  4. See error

Expected behavior
SWIFTPM_MODULE_BUNDLE will be generated by Xcode for tuist SPM dependencies

macOS 12, Xcode 13.1, tuist 2.3.2

@danieleformichelli
Copy link
Collaborator

Hello Pavel 👋

Thanks for reporting this 🙏

I think we are missing 2 pieces here in order for this to work:

  1. as far as I can see, currently we generate bundle accessors only for Swift (cc @pepicrft @fortmarek to confirm)
  2. once we generate bundle accessors also for ObjC, we would need to define the SWIFTPM_MODULE_BUNDLE in the PackageInfoMapper logic

For reference, the corresponding SPM logic can be found here.

@fortmarek
Copy link
Member

as far as I can see, currently we generate bundle accessors only for Swift

Correct, we don't have such logic for Objc - this would need to be added :(

@danieleformichelli
Copy link
Collaborator

@PSKuznetsov if you want to try to solve this, we can try to give you some pointers 🙌🙌

@makleso6
Copy link

makleso6 commented Sep 6, 2022

Same issue in my project 🙂

@eukurapov
Copy link

Is there a workaround for this? Except integrating the dependency via SPM directly.

@fortmarek fortmarek added the bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 label Jan 18, 2023
@github-actions
Copy link
Contributor

Hola 👋,

We want to inform you that the issue has been marked as stale. This means that there hasn't been any activity or updates on it for quite some time, and it's possible that it may no longer be relevant or actionable.
If you still believe that this issue is valid and requires attention, please provide an update or any additional information that can help us address it. Otherwise, we may consider closing it in the near future.
Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Resolving this issue is rewarded with a bounty: https://github.com/tuist/tuist/discussions/4982 type:enhancement New feature or request
Projects
None yet
7 participants