Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove custom error if service not found and create response standart response dto #47

Merged
merged 4 commits into from
Jan 17, 2022

Conversation

Yozhef
Copy link
Member

@Yozhef Yozhef commented Jan 16, 2022

No description provided.

@Yozhef Yozhef changed the title Feat/add response dto Feat: remove custom error if service not found and create response standart response dto Jan 16, 2022
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #47 (94c85ee) into story/Release1 (783aba9) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             story/Release1      #47      +/-   ##
====================================================
+ Coverage             98.50%   98.64%   +0.14%     
- Complexity               20       23       +3     
====================================================
  Files                     8        7       -1     
  Lines                    67       74       +7     
====================================================
+ Hits                     66       73       +7     
  Misses                    1        1              
Impacted Files Coverage Δ
src/Check/DoctrineCheck.php 100.00% <100.00%> (ø)
src/Check/EnvironmentCheck.php 100.00% <100.00%> (ø)
src/Check/StatusUpCheck.php 100.00% <100.00%> (ø)
src/Controller/HealthController.php 100.00% <100.00%> (ø)
src/Dto/Response.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783aba9...94c85ee. Read the comment docs.

@Yozhef Yozhef merged commit ce8335d into story/Release1 Jan 17, 2022
@Yozhef Yozhef deleted the feat/addResponseDto branch January 17, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants