Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Update to manylinux2010 #62

Closed
rth opened this issue Jul 14, 2020 · 4 comments
Closed

Update to manylinux2010 #62

rth opened this issue Jul 14, 2020 · 4 comments

Comments

@rth
Copy link
Contributor

rth commented Jul 14, 2020

From https://www.python.org/dev/peps/pep-0571/#id48

CentOS 5.11 [used to build manylinux1] reached its end-of-life on March 31st, 2017 with a clear warning against its continued use

Should we update the wheels to manylinux2010? Or at least would it be OK to build manylinux2010 directly in scikit-learn/scikit-learn#17921 (comment) ?

BTW,

CentOS 6 [used for manylinux2010] is now the oldest supported CentOS release, and will receive maintenance updates through November 30th, 2020.

In general, are there some guidelines as to when one should update the manylinux version?

Edit: I guess the thread from pypa/manylinux#179 (comment) answers some of these questions.

In particular manylinux2010 would require pip > 19.0

@mattip
Copy link

mattip commented Jul 14, 2020

You can use multibuild to build and test any current manylinux wheel, including arm64 and pypy. Over at numpy-wheels we are using travis (for arm64 and pypy linux64) and azure (for all the rest), and we ship manylinux1 (for legacy), manylinux2010 (which is the majority) and manylinux2014 for arm64.

@thomasjpfan
Copy link
Collaborator

thomasjpfan commented Jul 14, 2020

On numpy-wheels, were you able to build and run the complete test suite when building for arm64? (Within the 1 hr time limit that travis sets)

@mattip
Copy link

mattip commented Jul 14, 2020

Yup (I hope you can see the link to the test-runs). But the runs are about 2x slower than our azure ones

@ogrisel
Copy link
Contributor

ogrisel commented Nov 9, 2020

The new cibuildwheel-based system in scikit-learn master is already building 2010 wheel by default. I don't think we need to generate manylinux1 wheels for scikit-learn anymore.

@ogrisel ogrisel closed this as completed Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants