Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

MAINT: prevent universal2 thin upload #156

Closed
wants to merge 1 commit into from

Conversation

tylerjereddy
Copy link
Collaborator

Fixes #155 (check logs to verify though)

uploading wheelhouse/scipy-1.8.0rc1-cp39-cp39-macosx_11_0_arm64.whl wheelhouse/scipy-1.8.0rc1-cp39-cp39-macosx_12_0_universal2.whl
  • the solution I've opted for here is to do a verbose deletion
    of the *arm64.whl file in universal2 workflows only, followed
    by a listing of files in wheelhouse path to increase confidence
    when examining logs, etc.

  • note that since we can't really test the thin arm64 wheels in
    CI anyway, another viable option would be to rename the thin wheels
    in the universal2 jobs to use 12_0, upload both of those wheels,
    and delete the individual thin arm64 wheel build CI jobs; for now,
    I've opted for the solution that is more convenient for me--we may
    be able to save electricity the other way, but we are also perhaps
    interested in removing the universal2 builds some day, which might
    be more work if we purge out the isolated thin arm64 builds now..

cc @rgommers @isuruf

* it turns out that the `universal2` jobs in CI
include generation of the thin arm64 wheel artifacts,
which then get uploaded with the undesired `11_0` names,
as per this log for `1.8.0rc1`:
https://dev.azure.com/numpy/27346c6a-2774-4eac-bf85-e068127c0ccc/_apis/build/builds/21654/logs/200

* since the logs tend to disappear for Azure, it says:
```
uploading wheelhouse/scipy-1.8.0rc1-cp39-cp39-macosx_11_0_arm64.whl wheelhouse/scipy-1.8.0rc1-cp39-cp39-macosx_12_0_universal2.whl
```

* the solution I've opted for here is to do a verbose deletion
of the `*arm64.whl` file in `universal2` workflows only, followed
by a listing of files in `wheelhouse` path to increase confidence
when examining logs, etc.

* note that since we can't really test the thin arm64 wheels in
CI anyway, another viable option would be to rename the thin wheels
in the universal2 jobs to use `12_0`, upload both of those wheels,
and delete the individual thin arm64 wheel build CI jobs; for now,
I've opted for the solution that is more convenient for me--we may
be able to save electricity the other way, but we are also perhaps
interested in removing the universal2 builds some day, which might
be more work if we purge out the isolated thin arm64 builds now..
@tylerjereddy
Copy link
Collaborator Author

should be backported once working, and before 1.8.0rc2

@isuruf
Copy link
Contributor

isuruf commented Dec 19, 2021

I'm not sure why there are two jobs osx-Py39-universal2, osx-Py39_arm64. Only the former is needed.

@tylerjereddy
Copy link
Collaborator Author

I'm not sure why there are two jobs osx-Py39-universal2, osx-Py39_arm64. Only the former is needed.

See discussion above--it is not like I didn't think about this, so I'm open to other solutions, although this may be the least work for me for now.

@tylerjereddy
Copy link
Collaborator Author

Closed in favor of gh-157.

@tylerjereddy tylerjereddy deleted the treddy_issue_155 branch December 19, 2021 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.8.0rc1 includes 11_0 and 12_0 arm64 thin wheels
2 participants