This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155 (check logs to verify though)
it turns out that the
universal2
jobs in CIinclude generation of the thin arm64 wheel artifacts,
which then get uploaded with the undesired
11_0
names,as per this log for
1.8.0rc1
:https://dev.azure.com/numpy/27346c6a-2774-4eac-bf85-e068127c0ccc/_apis/build/builds/21654/logs/200
since the logs tend to disappear for Azure, it says:
the solution I've opted for here is to do a verbose deletion
of the
*arm64.whl
file inuniversal2
workflows only, followedby a listing of files in
wheelhouse
path to increase confidencewhen examining logs, etc.
note that since we can't really test the thin arm64 wheels in
CI anyway, another viable option would be to rename the thin wheels
in the universal2 jobs to use
12_0
, upload both of those wheels,and delete the individual thin arm64 wheel build CI jobs; for now,
I've opted for the solution that is more convenient for me--we may
be able to save electricity the other way, but we are also perhaps
interested in removing the universal2 builds some day, which might
be more work if we purge out the isolated thin arm64 builds now..
cc @rgommers @isuruf