This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Fix universal2 wheel name and remove redundant builds #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-posix.yml
Outdated
|
|
||
| - bash: | | ||
| set -xe | ||
| for file in `find ./wheelhouse -type f -name '*10_9_universal2.whl'`; do mv -v "$file" "${file/10_9_universal2/12_0_universal2}"; done | ||
| for file in `find ./wheelhouse -type f -name '*10_9_universal2.whl'`; do mv -v "$file" "${file/macosx_10_9_universal2/macosx_12_0_arm64.macosx_10_9_x86_64}"; done |
There was a problem hiding this comment.
Are you changing the name of the wheel to no longer include universal2? I dunno, I was just hoping to minimize the number of changes that get backported, even if the risk is slim. I guess you may be pretty confident it will do the right thing..
Still, I'm not sure we are particularly keen on retaining universal2 long-term anyway..
There was a problem hiding this comment.
Yes. It's still a universal2 wheel, but this is to workaround a pip limitation.
|
Ok, I'll trust that you're close to 100 % confident that this won't introduce new problems compared to the simple solution in gh-156. Merging, thanks. |
This was referenced Dec 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tylerjereddy