Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace JSON with 1.5.1 #26

Merged
merged 4 commits into from
May 19, 2011
Merged

replace JSON with 1.5.1 #26

merged 4 commits into from
May 19, 2011

Conversation

Watson1978
Copy link
Member

Like CRuby, I replaced the JSON with 1.5.1 which distributed in http://flori.github.com/json/

@lrz
Copy link
Member

lrz commented May 19, 2011

Nice work! I have a couple questions:

  1. what does this new JSON implementation bring compared to the current one? Is the current one not good or does not conform to CRuby?

  2. is there a test/spec suite that we can use to check if it works as expected? I'm quite worried about memory management, because MacRuby's GC is different, and C extensions can sometimes not work properly or can leak memory under MacRuby.

@Watson1978
Copy link
Member Author

Thank you for your comment :)

  1. This implement will solve,
  1. fix a #1275 "JSON library outdated or broken"
  2. Cost of the maintenance will decrease. currently implement is MacRuby original.
    I think what somebody of MacRuby Team continues maintaining all the time will be high cost.
  1. unit test exists in "test/test-mri/test/json/test_*.rb"
    The test seemed to work well.

@lrz
Copy link
Member

lrz commented May 19, 2011

OK, I agree, please go ahead and merge! Thanks for the work :)

@Watson1978 Watson1978 merged commit f9f0b29 into MacRuby:master May 19, 2011
@Watson1978
Copy link
Member Author

Thank you!
I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants