TIMOB-9844: BlackBerry: Include/require framework's .js files #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Issues Fixed] TIMOB-9844: BlackBerry: Include/require framework's .js files [Changes] TiMessageStrings.h - added error string TiRootObject.cpp - function executeScript - read and run the bootstrap.js file [Tests] Test 1: Build Mobile SDK and run an app 1) Put some test code in bootstrap.js (eg a string variable) 2) Run scons 3) Verify the build succeeds and the framework's .js files are in the Mobile SDK .zip file 4) Extract the Mobile SDK .zip file and create a project using project.py 5) Edit app.js to use the bootstrap.js test code 6) Build, package, and run the app 7) Verify there are no errors and the bootstrap.js test code is working
|
Reviewed |
|
Approved with comments |
| @@ -21,6 +21,7 @@ | |||
| namespace Msg | |||
| { | |||
|
|
|||
| TIMESSAGESTRINGS_CONST_DEF(char*, ERROR__Cannot_load_bootstrap_js, "ERROR: Cannot load bootstrap.js!\n"); | |||
There was a problem hiding this comment.
I would say, remove also \n, since we already have it in log().
|
Reviewed |
Fixed error string and ifstream check. Also removed the extra endlines.
|
Updated patch |
|
Approved |
dlifshitz-maca
added a commit
that referenced
this pull request
Jul 6, 2012
TIMOB-9844: BlackBerry: Include/require framework's .js files [Issues Fixed] TIMOB-9844: BlackBerry: Include/require framework's .js files [Changes] TiMessageStrings.h - added error string TiRootObject.cpp - function executeScript - read and run the bootstrap.js file [Tests] Test 1: Build Mobile SDK and run an app 1) Put some test code in bootstrap.js (eg a string variable) 2) Run scons 3) Verify the build succeeds and the framework's .js files are in the Mobile SDK .zip file 4) Extract the Mobile SDK .zip file and create a project using project.py 5) Edit app.js to use the bootstrap.js test code 6) Build, package, and run the app 7) Verify there are no errors and the bootstrap.js test code is working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Alex, David C
Note: Depends on #89