Document a caveat of isHomogeneous #335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isHomogeneous only looks at the given generators and relations of a
module. Therefore it can return the value false even for homogeneous
modules. Extend the documentation to highlight this.
Maybe we have discussed this in person at some point? I somehow remember that the behaviour should not be changed for performance reasons. In any case, I was recently bitten by it, so it should be documented properly.