Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a caveat of isHomogeneous #335

Merged
merged 1 commit into from Aug 29, 2015

Conversation

tom111
Copy link
Contributor

@tom111 tom111 commented Aug 28, 2015

isHomogeneous only looks at the given generators and relations of a
module. Therefore it can return the value false even for homogeneous
modules. Extend the documentation to highlight this.

Maybe we have discussed this in person at some point? I somehow remember that the behaviour should not be changed for performance reasons. In any case, I was recently bitten by it, so it should be documented properly.

isHomogeneous only looks at the given generators and relations of a
module.  Therefore it can return the value false even for homogeneous
modules.  Extend the documentation to highlight this.
@DanGrayson
Copy link
Member

Looks good to me.

It probably never happens that a user needs help converting inhomogeneous generators to
homogeneous ones, so avoiding computation is probably wise, even though the value
returned depends on the chosen generators and not on just the ideal.

@tom111
Copy link
Contributor Author

tom111 commented Aug 28, 2015

A few more thoughts:

  • Hopefully all the existing code using this was written with the convention in mind.
  • The function "isBinomial" in the Binomials package computes the reduced Gröbner basis before answering.
  • To be completely explicit one could have two functions "isHomogeneous" and "isPresentedHomogeneously" (or some other less awkward name).

@DanGrayson
Copy link
Member

No need for something like "isPresentedHomogeneously" when "isHomogeneous gens" does the same thing. Unfortunately, for modules, which are always submodules, there are two matrices that have to be examined, and "presentation" doesn't return the pair of them.

DanGrayson added a commit that referenced this pull request Aug 29, 2015
Document a caveat of isHomogeneous
@DanGrayson DanGrayson merged commit 962dcc3 into Macaulay2:master Aug 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants