Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit: Added console weapon commands, added Machete, Cannon, Melee, Elephantgun #844

Merged
merged 8 commits into from Mar 12, 2012

Conversation

Tipaa
Copy link
Contributor

@Tipaa Tipaa commented Mar 7, 2012

Basics for a melee system, and two (somewhat whimsical) guns that could be niche weapons - Cannon is a bomb launcher, and elephant gun is great for the pharaoh.

I have also added weapon and cash /give to the console, and fixed a transparency issue.

@master-lincoln
Copy link
Collaborator

Please remove the Thumbs.db files

@master-lincoln
Copy link
Collaborator

Otherwise the pull request looks nice.
+1

@danielduner
Copy link
Contributor

This seems to do many things at the same time and add weapons that have not been discussed?

@master-lincoln
Copy link
Collaborator

Yeah we have to discuss about it. We would also need a way to buy these weapons.They could be enabled if you reach a certain XP Level.
And it only includes the weapons and a few new console commands.
4 of them are unrelated and could be externalized to a new pull request which we could merge now.

EDIT
I just tried it and like the ideas.
We would need some kind of indication while a weapon is loading.
Also an extra animation for the machete needs to be done...

com.mojang.mojam.entity.weapon.Machete.attackDelay=35

com.mojang.mojam.entity.weapon.Melee.bulletDamage=1.5
com.mojang.mojam.entity.weapon.Melee.attackDelay=30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used. instead I get an error because shootDelay is not defined. Why not leave this shootDelay

@Tipaa
Copy link
Contributor Author

Tipaa commented Mar 9, 2012

I have fixed the constants with the latest commit - I just wanted to have a good animation before spamming commits.

@Maescool
Copy link
Owner

@Tipaa sync up :)

@master-lincoln
Copy link
Collaborator

What do the others think about this pull request?
This doesn't change current gameplay unless you use the console. It's good to have some new weapons ready if someone comes up with a good integration in the game...

@Flet
Copy link
Collaborator

Flet commented Mar 12, 2012

go for it

Maescool added a commit that referenced this pull request Mar 12, 2012
Commit: Added console weapon commands, added Machete, Cannon, Melee, Elephantgun
@Maescool Maescool merged commit 569b638 into Maescool:develop Mar 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants