Cleanup Kernel.select #346

Merged
merged 3 commits into from Nov 5, 2014

2 participants

@johnnyt
MagLev Engineering Team member

Closes #345. This also consolidates the code from IO#select into Kernel.select.

@MagLev - what do you guys think?

johnnyt added some commits Mar 6, 2014
@johnnyt johnnyt Centralize select system call b8996f2
@johnnyt johnnyt Allow nil timeouts d51788d
@johnnyt johnnyt Test for #345
1800812
@timfel
MagLev Engineering Team member

Shouldnt IO already respond to select because it includes Kernel? If so, maybe the argument error should print the correct class this was called on? What error(s) does MRI raise? Is there a Rubyspec? Just thinking that if we touch the code, we might fix a spec or two

@timfel
MagLev Engineering Team member

Since this still passes, I'll just merge it.

@timfel timfel merged commit 0abcc19 into master Nov 5, 2014

2 checks passed

Details continuous-integration/travis-ci The Travis CI build passed
Details default The Travis CI build passed
@johnnyt johnnyt deleted the johnnyt/github345 branch Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment