Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps and remove stylelint fix #3120

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jun 8, 2023

there are no "all" files in the v5 versions of roboto-fonts anymore so I used the content of their css files in roboto.css

coming with separate PR

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #3120 (6d3c222) into develop (a56b929) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
+ Coverage    25.59%   25.64%   +0.04%     
===========================================
  Files           53       53              
  Lines        11435    11435              
===========================================
+ Hits          2927     2932       +5     
+ Misses        8508     8503       -5     

see 1 file with indirect coverage changes

@rejas
Copy link
Collaborator

rejas commented Jun 8, 2023

Could we split the roboto font changes into a seperate PR which we can have a little longer in the develop branch? Having all these new css fonts makes me nervous a month before the next release :-)

@khassel khassel changed the title update fonts, update deps and remove stylelint fix update deps and remove stylelint fix Jun 8, 2023
@khassel
Copy link
Collaborator Author

khassel commented Jun 8, 2023

Having all these new css fonts makes me nervous a month before the next release :-)

coward 😜

removed fonts stuff, coming with new PR ...

@rejas
Copy link
Collaborator

rejas commented Jun 8, 2023

coward 😜

experienced :-P

@rejas rejas merged commit b737153 into MagicMirrorOrg:develop Jun 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants