Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set python_requires #401

Merged
merged 1 commit into from Feb 19, 2021
Merged

set python_requires #401

merged 1 commit into from Feb 19, 2021

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Feb 18, 2021

currently when installing uvloop (without pins) pip on py3.6 will download 0.15.1 and then fail. Setting requires_python means pip can pick a different version to install

0.15.0 and 0.15.1 will need to be yanked to avoid issues like encode/uvicorn#953

@1st1 1st1 requested a review from fantix February 18, 2021 23:18
@1st1
Copy link
Member

1st1 commented Feb 18, 2021

@fantix let's merge and issue 0.15.2 release?

Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fantix
Copy link
Member

fantix commented Feb 19, 2021

@fantix let's merge and issue 0.15.2 release?

Yeah, makes sense to me 👍

@fantix fantix merged commit c808a66 into MagicStack:master Feb 19, 2021
@graingert graingert deleted the patch-1 branch February 19, 2021 07:00
@fantix
Copy link
Member

fantix commented Feb 19, 2021

This is released as 0.15.2 in #402. Thank you for the PR!

@graingert
Copy link
Contributor Author

graingert commented Feb 19, 2021

@fantix you'll need to yank 0.15.0 and 0.15.1 for this to work, currently I still get:

  Downloading uvloop-0.15.1.tar.gz (2.1 MB)
     |████████████████████████████████| 2.1 MB 3.5 MB/s 
    ERROR: Command errored out with exit status 1:

graingert added a commit to graingert/uvicorn that referenced this pull request Feb 19, 2021
Now that uvloop sets python_requires the pinning isn't needed, but we do need to
ignore the packages with missing python_requires

MagicStack/uvloop#401
euri10 pushed a commit to encode/uvicorn that referenced this pull request Feb 20, 2021
Now that uvloop sets python_requires the pinning isn't needed, but we do need to
ignore the packages with missing python_requires

MagicStack/uvloop#401
@fantix
Copy link
Member

fantix commented Feb 21, 2021

@fantix you'll need to yank 0.15.0 and 1.15.1 for this to work, currently I still get:

  Downloading uvloop-0.15.1.tar.gz (2.1 MB)
     |████████████████████████████████| 2.1 MB 3.5 MB/s 
    ERROR: Command errored out with exit status 1:

@1st1 wdyt pls?

@graingert
Copy link
Contributor Author

@1st1 @fantix I'm still getting this issue, can you please yank the packages with the incorrect metadata?

Devops555 pushed a commit to Devops555/uvicorn that referenced this pull request Aug 7, 2021
Now that uvloop sets python_requires the pinning isn't needed, but we do need to
ignore the packages with missing python_requires

MagicStack/uvloop#401
cr313 added a commit to cr313/py-project-uvicorn that referenced this pull request Apr 19, 2024
Now that uvloop sets python_requires the pinning isn't needed, but we do need to
ignore the packages with missing python_requires

MagicStack/uvloop#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants