-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex Float32 data are not well handle #103
Comments
yes these need to be fixed but in a clever way. The point is that the user will often specify TE, AQ, lambda ... using Float64 even if the data should be reconstructed in Float32. Thus, these parameters should be promoted to the eltype of the array instead of enforcing them to be of the same type as the array (or in this case the first argument of the function). |
I'll put that on my to do. Especially for all the high level functions.
Le ven. 9 sept. 2022 à 21:27, Tobias Knopp ***@***.***> a
écrit :
… yes these need to be fixed but in a clever way. The point is that the user
will often specify TE, AQ, lambda ... using Float64 even if the data should
be reconstructed in Float32. Thus, these parameters should be promoted to
the eltype of the array instead of enforcing them to be of the same type as
the array (or in this case the first argument of the function).
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5P7O7MRXG644EGJFIFNXDV5OFRBANCNFSM6AAAAAAQI2YOJM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks !
Le ven. 30 sept. 2022 à 19:29, migrosser ***@***.***> a
écrit :
… Commit d1efe5d
<d1efe5d>
should fix the issue with the type of TE and AQ in the trajectories.
Furthermore, I changed setupIterativeReco so that the type of lambda is
adapted to the underlying datatype in AcquisitionData in commit b84a9ee
<b84a9ee>
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5P7OYAAA4OFPTBUM36MPLWA4PQPANCNFSM6AAAAAAQI2YOJM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on a benchmark against bart (which is using Float32). I wanted to create a data acq with that possibility.
One of the issue was in CartesianTrajectory3D
I had to change the type of the keyword parameters to Float32
Should we change that ?
It is also the same issue for the reconstruction regularization parameters
The text was updated successfully, but these errors were encountered: