117 scaling behavior with number of lines #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s opacity and emissivity. Improves default performance in case of multi-line models. Decreases performance in single-line models.
Note: still needs to be implemented for the compute_s_dtau routine.
Note: old behavior can be obtained by setting the parameter sum_opacity_emissivity_over_all_lines to True
|
Note: this pull request will create some conflicts with #113 , due to adding a few lines of code in |
FredDeCeuster
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New default behavior for computing opacities/emissivities; now only takes into consideration the nearby lines.
This improves the scaling behavior to O(N ln(N)) instead of O(N^2).
For those who still want the old behavior: it can be reenabled by setting the new parameter sum_opacity_emissivity_over_all_lines to True (see
parameters.hpp).