Refactor feautrier solvers #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot yet connected to anything)
…faster than the default variant. See changed benchmark file. It produces the same results so something is clearly wrong here... This might be due to memory optimization.
…s faster than the default feautrier solver.
|
We'll discuss this in October. |
This was referenced Oct 7, 2022
|
To summarize: readd MPI, readd pointer copies, accelerator synchronize, ... |
|
Due to implicit differences between the sparse and non-sparse solvers, this refactoring will prove useless. Aborting this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By refactoring the feautrier solvers, it should be easier to add additional feautures (such as pressure computation, mean intensities, ...) to them if necessary. By defining template parameters (and assert statements), it is also a bit easier to know which solvers do what exactly.
Important notice: the minimal C++ version has been increased to C++17, as compile time evaluation of (constexpr) if statements is introduced in that version.