Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar button should overlap WindowCommands #1936

Closed
xmedeko opened this issue May 26, 2015 · 2 comments · Fixed by #3503
Closed

Title bar button should overlap WindowCommands #1936

xmedeko opened this issue May 26, 2015 · 2 comments · Fixed by #3503
Assignees
@punker76
Labels
Feature Request
Milestone
2.0.0

Comments

@xmedeko
Copy link

xmedeko commented May 26, 2015

I have Controls:MetroWindow.LeftWindowCommands containing a menu. When a user resizes window to be very narrow, then the Minimize, Maximize and Close buttons start disappearing, but the WindowCommands stays. (The close button is already missing on the image bellow.)

Small Window

I think the right behaviour should be the opposite - the title bar buttons are the most important and they should stay last.
@Henka-Programmer
Copy link

yes you are right i think it should be work like the WPF Toolbar, i means overly the commands in a popup or an other strategy like adding two arrow left right to navigate the command or some think like that to avoid this Issue. thank you xmedeko.

@punker76 punker76 self-assigned this Sep 10, 2015
@punker76 punker76 added this to the 2.0.0 milestone May 20, 2019
@punker76
Copy link
Member

See also #3408

punker76 added a commit that referenced this issue May 20, 2019
@punker76
(GH-1936, GH-3408) Improvement for title bar and window commands
779b1ce 
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size.

To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control.

The default window style is now changed to use this new mechanism.

These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command should not overlay when a Flyout is open.

The clean centered style still needs changes for the centered title behavior.
@punker76 punker76 mentioned this issue May 20, 2019
Merged
punker76 added a commit that referenced this issue May 21, 2019
@punker76
(GH-1936, GH-3408) Fix centered title style
2ed1ef9 
The centered window title style works now also with the new window commands overflow mechanism.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fixes and improvements for the new feature
3ea13b8 
- Improve toggle button mouse over and checked visual (change background and foreground)
- Fix binding for Foreground and Background of the inner controls of the WindowCommandsItem
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Improvement for title bar and window commands
b43075e 
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size.

To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control.

The default window style is now changed to use this new mechanism.

These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command should not overlay when a Flyout is open.

The clean centered style still needs changes for the centered title behavior.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fix centered title style
4fdecc3 
The centered window title style works now also with the new window commands overflow mechanism.
punker76 added a commit that referenced this issue May 23, 2019
@punker76
(GH-1936, GH-3408) Fixes and improvements for the new feature
676323b 
- Improve toggle button mouse over and checked visual (change background and foreground)
- Fix binding for Foreground and Background of the inner controls of the WindowCommandsItem
punker76 added a commit that referenced this issue May 24, 2019
@punker76
(GH-1936, GH-3408) Try fix Codacy/PR Quality Review issue
1a234ca 
The 'ParentWindowCommands' must not be a static property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Feature Request
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Improvement for title bar and window commands MahApps/MahApps.Metro
3 participants
@punker76 @xmedeko @Henka-Programmer