Improvement for title bar and window commands #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size. To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control. The default window style is now changed to use this new mechanism. These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command should not overlay when a Flyout is open. The clean centered style still needs changes for the centered title behavior.
punker76
force-pushed
the
feature/TitleBar_Overflow
branch
from
3ea13b8
to
676323b
Compare
punker76
changed the title
punker76
added a commit
that referenced
this pull request
May 28, 2019
…havior_Breaking_change Change window commands overlay behavior after title bar changes (GH-3503)
punker76
added a commit
that referenced
this pull request
May 29, 2019
Before the new title bar feature the default overlay behavior for Left and Right window commands was set to Flyouts. To get the same result the new default must now set to Never. The parent DockPanel also doesn't need set their height to the title bar height.
punker76
added a commit
that referenced
this pull request
May 29, 2019
…avior The new default behavior is Never, so this test should test for this too.
punker76
added a commit
that referenced
this pull request
May 29, 2019
…d event Fix possible exception which can occurred during a resize together with the centered window template. This can be happen if there is a custom window template different to the default ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
If there are more then 2 or 3 window commands on the right or left site and the user resizes the window then the Min, Max, Close buttons move out the window and open dialogs will not resize to a slower size.
To solve this I changed the window commands control from ItemsControl to ToolBar class which allows us to use the overlow mechanism of this control.
Additional context
These changes causes also a breaking change to the window commands overlay behavior. This feature will be removed, because a window command can now not overlay a Flyout if it's open.
Closed Issues
Closes #1936
Closes #3408