create new class of Thumb in order to be better in Touch environment #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ycaoyang Make sure to add your thumb class to the same directory in the MahApps.Metro.NET45 solution as well. |
|
@ALL can someone test this? I don't have a touch device... |
|
is this fix present in one of the current alpha releases available on nuget? if so, i'll test it with pleasure (on only one touch device though) |
|
@Kalashn you can clone this pr |
|
@punker76 ;Thanks, I quite new to github. I'll run the tests this weekend. Any procedures or tools I have to use? Otherwise it will be just a basic: is it working as expected (and proposed as better) test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In touch environment, touching a slider won't make its thumb following user's finger, for another visual has capture the touch-device. In order to make the Thumb touchable, we have to capture the touch-device in himself. So here it is.
PS : correct branch selection