Change window commands overlay behavior after title bar changes (GH-3503) #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the package references and add *.binlog to git ignore.
Split WindowCommandsOverlayBehavior into 2 separate enumerations. WindowCommandsOverlayBehavior for Left and Right window commands and OverlayBehavior for Icon and WindowButton commands. WindowCommandsOverlayBehavior contains now only 2 enumeration values (Never and HiddenTitleBar).
The new overlay behavior of the window commands needs also new overlay brushes. Because the window commands now doesn't overlay the Flyouts and so it's not necessary to set a calculated overlay brush for the foreground.
punker76
deleted the
feature/WindowCommandsOverlayBehavior_Breaking_change
branch
This was referenced Sep 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
After improving the title bar in #3503 the window commands and window button commands needs also a change for the overlay brushes.
Split WindowCommandsOverlayBehavior into 2 separate enumerations.
WindowCommandsOverlayBehaviorfor Left and Right window commandsOverlayBehaviorfor Icon and WindowButton commandsWindowCommandsOverlayBehaviorcontains now only 2 enumeration values (Never and HiddenTitleBar)The new overlay behavior of the window commands needs also new overlay brushes. Because the window commands now doesn't overlay the Flyouts and so it's not necessary to set a calculated overlay brush for the foreground.