Fixes flaky test #1592

MaibornWolff · May 25, 2021 · 63ea198 · 63ea198
1 parent 98dfe19
commit 63ea198
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/visualization/app/codeCharta/ui/rangeSlider/rangeSlider.component.spec.ts b/visualization/app/codeCharta/ui/rangeSlider/rangeSlider.component.spec.ts
@@ -47,7 +47,6 @@ describe("RangeSliderController", () => {
 		withMockedMetricService()
 		rebuildController()
 		initFiles()
-		spyOn($rootScope, "$broadcast")
 	})
 
 	function withMockedMetricService() {
@@ -103,9 +102,11 @@ describe("RangeSliderController", () => {
 		})
 
 		it("should have called rzSliderForceRender", () => {
+			const spy = spyOn(RangeSliderController.prototype, "renderSliderOnInitialisation")
+
 			rebuildController()
 
-			expect($rootScope.$broadcast).toBeCalledWith("rzSliderForceRender")
+			expect(spy).toHaveBeenCalled()
 		})
 	})
 

diff --git a/visualization/app/codeCharta/ui/rangeSlider/rangeSlider.component.ts b/visualization/app/codeCharta/ui/rangeSlider/rangeSlider.component.ts
@@ -76,13 +76,18 @@ export class RangeSliderController
 	renderSliderOnInitialisation() {
 		// quick and dirty: Better solution would be to wait for the content to be loaded for the first render
 		// should be taken care of when switching to Angular
+
 		angular.element(() => {
 			this.$timeout(() => {
-				this.$rootScope.$broadcast("rzSliderForceRender")
+				this.forceSliderRender()
 			})
 		})
 	}
 
+	forceSliderRender() {
+		this.$rootScope.$broadcast("rzSliderForceRender")
+	}
+
 	onBlacklistChanged() {
 		if (this.isMaxMetricValueChanged()) {
 			this.updateMaxMetricValue()