Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive design: metrics not visible on smaller width #1037

Closed
BridgeAR opened this issue Jul 4, 2020 · 4 comments · Fixed by #1912
Closed

Responsive design: metrics not visible on smaller width #1037

BridgeAR opened this issue Jul 4, 2020 · 4 comments · Fixed by #1912
Assignees
@Christian-Eberhard @Shivan-997
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Milestone
bug-hunt

Comments

@BridgeAR
Copy link
Member

BridgeAR commented Jul 4, 2020

Bug

Expected Behavior

GIVEN a map opened with the visualizer

WHEN minify the window to have a smaller screen / in case the width is small in general

THEN the metrics are all visible or better: it's possible to click to the other metrics

Actual Behavior

The metrics are invisible and it's impossible to get there / know about the missing ones

Screenshots

image

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.49.1
  • OS: Ubuntu 20.04
  • Browser: Chromium
@BridgeAR BridgeAR added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jul 4, 2020
@NearW
Copy link
Contributor

NearW commented Jul 4, 2020

Uh, responsive design... The last time we spoke about this with our previous PO we decided to not support screen resolutions less than 1440x900..? I'm not 100% sure at this point.

@BridgeAR BridgeAR added the priority:low Set by PO label Jul 4, 2020
@BridgeAR
Copy link
Member Author

BridgeAR commented Jul 4, 2020

Most parts seem to be responsive. This seems like a minor part that is missing and I would still fix that with a low priority.

@BridgeAR BridgeAR added priority:high Set by PO and removed priority:low Set by PO labels Dec 23, 2020
@BridgeAR BridgeAR changed the title Metrics not visible on smaller width Responsive design: metrics not visible on smaller width Dec 24, 2020
@BridgeAR BridgeAR mentioned this issue Dec 24, 2020
Closed
@BridgeAR
Copy link
Member Author

Text from #1423:

  • CodeCharta visualization is responsive, scaling to the screen size and behaving as expected on smaller screens.
  • However, the top bar features set heights and widths making it difficult to use on smaller windows, with some feature like edge settings being unreachable.
  • The size for components like the blacklist or the flattenend list might also be an issue in such cases.

Making the website responsive for smaller devices, e.g. Pads and Phones might improve user experience and increase usability.

@BridgeAR
Copy link
Member Author

This should also be fixed while being at it:

image

The icon has some fixed space to the next part.

@BridgeAR BridgeAR added this to the bug-hunt milestone Jan 1, 2021
@Shivan-997 Shivan-997 self-assigned this Feb 26, 2021
@Christian-Eberhard Christian-Eberhard self-assigned this Mar 25, 2021
Christian-Eberhard pushed a commit that referenced this issue Mar 31, 2021
Removes unused whitespaces in the searchbar,
dac63df 
Removes the usage of ids as selectors,
Adds semi responsiveness for the metric cards #1037
@Christian-Eberhard Christian-Eberhard mentioned this issue Apr 7, 2021
Merged
RomanenkoVladimir added a commit that referenced this issue Apr 16, 2021
@Christian-Eberhard @RomanenkoVladimir
Removes unused whitespaces in the searchbar (#1912)
da9167c 
* Removes unused whitespaces in the searchbar,
Removes the usage of ids as selectors,
Adds semi responsiveness for the metric cards #1037

* Updates changelog #1592

* Fix linting

* Update Changelog

Co-authored-by: ChristianE <christian.eberhard@maibornwolff.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christian-Eberhard Christian-Eberhard

@Shivan-997 Shivan-997

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
bug-hunt
Development

Successfully merging a pull request may close this issue.

Removes unused whitespaces in the searchbar MaibornWolff/codecharta
4 participants
@BridgeAR @NearW @Christian-Eberhard @Shivan-997