Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A grabbed color metric "threshold-button" can never be released #1319

Closed
ce-bo opened this issue Oct 2, 2020 · 0 comments · Fixed by #1345
Closed

A grabbed color metric "threshold-button" can never be released #1319

ce-bo opened this issue Oct 2, 2020 · 0 comments · Fixed by #1345
Assignees
@JaiJoPa
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Oct 2, 2020 •
edited

Bug

Expected Behavior

GIVEN
an opened Color Metric menu

WHEN
trying to release one of the two threshold buttons after changing the thresholds

THEN
the new threshoulds should be set and activated in the map accordingly.

Actual Behavior

the mouse focus is never released from the button and the color ranges can not be fixated ("disco lights" feature when moving the mouse across the screen).

Steps to Reproduce the Problem

  1. Try to change the color metric ranges using the range slider

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.57
  • OS: Windows
  • Browser: Chrome
@ce-bo ce-bo added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP labels Oct 2, 2020
@JaiJoPa JaiJoPa self-assigned this Oct 8, 2020
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Remove closing panels when clicking on codeCharta #1319
11a09ae
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Remove stop propagation from ribbonbar #1319
26e946f
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Add closing Panels function to toolbar and codemao #1319
7e16c08
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Adjust tests #1319
0f376fa
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Adjust test #1319
df2e7f3
JaiJoPa pushed a commit that referenced this issue Oct 8, 2020
Update changelog #1319
acd070a
@JaiJoPa JaiJoPa mentioned this issue Oct 8, 2020
Merged
RomanenkoVladimir added a commit that referenced this issue Oct 9, 2020
@JaiJoPa @BridgeAR @RomanenkoVladimir
Fix/1319/grabbed color metric can never be released (#1345)
25329fb 
* Remove closing panels when clicking on codeCharta #1319

* Remove stop propagation from ribbonbar #1319

* Add closing Panels function to toolbar and codemao #1319

* Adjust tests #1319

* Adjust test #1319

* Update changelog #1319

* Update visualization/app/codeCharta/ui/ribbonBar/ribbonBar.component.html

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Jaison John Palakat <JaisonP@mb-jaisonp.client.mwea.de>
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaiJoPa JaiJoPa

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/1319/grabbed color metric can never be released MaibornWolff/codecharta
2 participants
@ce-bo @JaiJoPa