Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zooming should close the nodes context menu #1324

Closed
BridgeAR opened this issue Oct 4, 2020 · 0 comments · Fixed by #1366
Closed

Zooming should close the nodes context menu #1324

BridgeAR opened this issue Oct 4, 2020 · 0 comments · Fixed by #1366
Assignees
@ce-bo
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO

Comments

@BridgeAR
Copy link
Member

BridgeAR commented Oct 4, 2020 •
edited

Bug

Expected Behavior

GIVEN a context menu being opened by a right click on a maps node

WHEN zooming in or out

THEN the context menu vanishes

Actual Behavior

The context menu stays around at the current position

Screenshots

image
image

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.58.1
@BridgeAR BridgeAR added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:medium Set by PO difficulty:low Solving this is likely not that difficult labels Oct 4, 2020
@ce-bo ce-bo self-assigned this Oct 12, 2020
ce-bo added a commit that referenced this issue Oct 12, 2020
@ce-bo
Fix existing e2e test, Close node context menu on wheel event #1324
014c576
ce-bo added a commit that referenced this issue Oct 12, 2020
@ce-bo
Fix e2e test #1324
6ec6100
ce-bo added a commit that referenced this issue Oct 12, 2020
@ce-bo
Add element visibility check based on aria-hidden attribute #1324
657482a
ce-bo added a commit that referenced this issue Oct 13, 2020
@ce-bo
Improve e2e test #1324
02d5888
ce-bo added a commit that referenced this issue Oct 13, 2020
@ce-bo
Fix line endings, Install fresh npm packages #1324
88ee36d
@ce-bo ce-bo mentioned this issue Oct 13, 2020
Merged
ce-bo added a commit that referenced this issue Oct 13, 2020
@ce-bo
Restore lost EventListener to listen for wheel events, Fix TypeError …
287690e 
…and emulate mouse wheel in e2e test #1324
ce-bo added a commit that referenced this issue Oct 14, 2020
@ce-bo
Fix and refactor NodeContextMenu component #1324
7c530cd
ce-bo added a commit that referenced this issue Oct 14, 2020
@ce-bo
Improve e2e test stability #1324
f895cbf
ce-bo added a commit that referenced this issue Oct 14, 2020
@ce-bo
Reset coverage flag #1324
bf492c7
ce-bo added a commit that referenced this issue Oct 14, 2020
@ce-bo
Playing around with the timeouts to fix long running test #1324
8e6ae4b
ce-bo added a commit that referenced this issue Oct 14, 2020
@ce-bo
Playing around with the timeouts to fix broken test #1324
38429ff
ce-bo added a commit that referenced this issue Oct 15, 2020
@ce-bo
Apply code style #1324
749844d
ce-bo added a commit that referenced this issue Oct 15, 2020
@ce-bo
Add wheel event listener to the codeMap element #1324
d6d2d94
ce-bo added a commit that referenced this issue Oct 15, 2020
@ce-bo
Try to fix broken test #1324
eff5a65
ce-bo added a commit that referenced this issue Oct 15, 2020
@ce-bo
Try to fix broken tests #1324
357a4aa
ce-bo added a commit that referenced this issue Oct 15, 2020
@ce-bo
Try to fix broken tests #1324
67ee129
ce-bo added a commit that referenced this issue Oct 16, 2020
@ce-bo
Improve names #1324
66622ec
ce-bo added a commit that referenced this issue Oct 16, 2020
@ce-bo
Simplify e2e tests using appropriate wait options #1324
2b01cab
ce-bo added a commit that referenced this issue Oct 16, 2020
@ce-bo
Update changelog #1324
836cf6b
ce-bo added a commit that referenced this issue Oct 16, 2020
@ce-bo
Feature/1324/close context menu on zoom (#1366)
dc3ef85 
* Fix existing e2e test, Close node context menu on wheel event #1324

* Fix e2e test #1324

* Add element visibility check based on aria-hidden attribute #1324

* Improve e2e test #1324

* Fix line endings, Install fresh npm packages #1324

* Restore lost EventListener to listen for wheel events, Fix TypeError and emulate mouse wheel in e2e test #1324

* Merge branch 'main' into feature/1324/close-context-menu-on-zoom

# Conflicts:
#	visualization/package.json

* Fix and refactor NodeContextMenu component #1324

* Improve e2e test stability #1324

* Reset coverage flag #1324

* Playing around with the timeouts to fix long running test #1324

* Playing around with the timeouts to fix broken test #1324

* Apply code style #1324

* Add wheel event listener to the codeMap element #1324

* Try to fix broken test #1324

* Try to fix broken tests #1324

* Try to fix broken tests #1324

* Improve names #1324

* Simplify e2e tests using appropriate wait options  #1324

* Update changelog #1324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ce-bo ce-bo

Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1324/close context menu on zoom MaibornWolff/codecharta
2 participants
@BridgeAR @ce-bo