Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better readability of the labels #1404

Closed
Gaugi28 opened this issue Oct 20, 2020 · 0 comments · Fixed by #1517
Closed

Better readability of the labels #1404

Gaugi28 opened this issue Oct 20, 2020 · 0 comments · Fixed by #1517
Assignees
@RomanenkoVladimir
Labels
feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP

Comments

@Gaugi28
Copy link

Gaugi28 commented Oct 20, 2020 •
edited

Feature request

Improve the readability of the labels, especially if all labels are shown.

Description

As an auditor, I want to select labels even if they are hidden behind other labels, so I can better analyze the code.

Acceptance criteria

  • if the user hovers over a label, it appears in the foreground
  • the user can click on the label and the building is selected
  • by clicking on the label, the view is automatically centered so that the selected building is the focus of the view

Example: labels should behave like the labels at Airbnb
image
image
@BridgeAR BridgeAR added priority:urgent Should be addressed ASAP feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Nov 11, 2020
RomanenkoVladimir added a commit that referenced this issue Nov 23, 2020
@RomanenkoVladimir
Add ability that Hovering/Selecting label will hover/select correspon…
f4a62a8 
…ding node #1404
RomanenkoVladimir added a commit that referenced this issue Nov 23, 2020
@RomanenkoVladimir
Fix intersect calculation, Refactor intersection calculation #1404
231859c
RomanenkoVladimir added a commit that referenced this issue Nov 23, 2020
@RomanenkoVladimir
Add the ability for hovered labels to move to front accordning to use…
6c062a6 
…r view point, still missing dynamic distance calculation #1404
RomanenkoVladimir added a commit that referenced this issue Nov 24, 2020
@RomanenkoVladimir
Change distance calculation #1404
700f5a1
RomanenkoVladimir added a commit that referenced this issue Nov 25, 2020
@RomanenkoVladimir
Add missing z-coordinate to vector calculation #1404
f54302c
RomanenkoVladimir added a commit that referenced this issue Nov 25, 2020
@RomanenkoVladimir
Add small movement to the front for unobstructed labels #1404
2734da9
RomanenkoVladimir added a commit that referenced this issue Nov 25, 2020
@RomanenkoVladimir
Make hovered label not transparent, Move color and opacity ahndling f…
170e204 
…rom canvas to threejs #1404
RomanenkoVladimir added a commit that referenced this issue Nov 25, 2020
@RomanenkoVladimir
Fix tests #1404
14764ab
@ce-bo ce-bo mentioned this issue Nov 26, 2020
Merged
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Change opacity to make the hovered label stand out more #1404
68497a1
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Add tests for intersection, Change dataMock to new opacity, Refactor …
1e0ed69 
…hovering method #1404
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Update Changelog #1404
aaa3a88
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Increase maximum label to 250 #1404
88a8722
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@ce-bo @RomanenkoVladimir
Feature/1404/label placement improvements (#1517)
620930c 
* All labels at the same height

* Add ability that Hovering/Selecting label will hover/select corresponding node #1404

* Fix intersect calculation, Refactor intersection calculation #1404

* Add the ability for hovered labels to move to front accordning to user view point, still missing dynamic distance calculation #1404

* Add label intersection calculation, issue with rotated labels under angle and vastly different label sizes#1404

* Change distance calculation #1404

* Add missing z-coordinate to vector calculation #1404

* Add small movement to the front for unobstructed labels #1404

* Make hovered label not transparent, Move color and opacity ahndling from canvas to threejs #1404

* Fix tests #1404

* Change opacity to make the hovered label stand out more #1404

* Add tests for intersection, Change dataMock to new opacity, Refactor hovering method #1404

* Update Changelog #1404

* Increase maximum label to 250 #1404

Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanenkoVladimir RomanenkoVladimir

Labels
feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1404/label placement improvements MaibornWolff/codecharta
3 participants
@BridgeAR @Gaugi28 @RomanenkoVladimir