Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Folder Algorithm should work for sub-folders #1431

Closed
ce-bo opened this issue Oct 26, 2020 · 0 comments · Fixed by #1471
Closed

Fixed Folder Algorithm should work for sub-folders #1431

ce-bo opened this issue Oct 26, 2020 · 0 comments · Fixed by #1471
Assignees
@ce-bo @Dmttr
Labels
feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Oct 26, 2020

Feature request

Description

As an Auditor, I also want to fixate sub-folders, so that the position of the sub-folder will not change, if a new file is added in the .cc.json file.

Development notes (optional Task Breakdown)

  • The existing algorithm propably has to work recursively.
@ce-bo ce-bo added feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Oct 26, 2020
@BridgeAR BridgeAR added the priority:urgent Should be addressed ASAP label Oct 26, 2020
@Dmttr Dmttr self-assigned this Oct 28, 2020
Dmttr added a commit that referenced this issue Oct 30, 2020
@Dmttr
hasFixedFolders inpects the whole map #1431
7f1b0bf
Dmttr added a commit that referenced this issue Nov 2, 2020
@Dmttr
Revert "hasFixedFolders inpects the whole map #1431"
d3645fb 
This reverts commit 7f1b0bf.
Dmttr added a commit that referenced this issue Nov 2, 2020
@Dmttr
recursion for buildSquarifiedTreeMaps (incomplete) #1431
6a10b7f
Dmttr added a commit that referenced this issue Nov 6, 2020
@Dmttr
apply scale and transform for X and Y coordinates #1431
e1a4d9e
@ce-bo ce-bo mentioned this issue Nov 9, 2020
Merged
ce-bo added a commit that referenced this issue Nov 9, 2020
@ce-bo
Fix scaling #1431
c077707
ce-bo added a commit that referenced this issue Nov 9, 2020
@ce-bo
Add some todos #1431
b3927f4
ce-bo added a commit that referenced this issue Nov 10, 2020
@ce-bo
Add some notes #1431
2009384
ce-bo added a commit that referenced this issue Nov 10, 2020
@ce-bo
Remove todo #1431
0cc82da
ce-bo pushed a commit that referenced this issue Nov 10, 2020
@Dmttr @ce-bo
hasFixedFolders inpects the whole map #1431
8d0945d
ce-bo pushed a commit that referenced this issue Nov 10, 2020
@Dmttr @ce-bo
Revert "hasFixedFolders inpects the whole map #1431"
58a641c 
This reverts commit 7f1b0bf.
ce-bo pushed a commit that referenced this issue Nov 10, 2020
@Dmttr @ce-bo
recursion for buildSquarifiedTreeMaps (incomplete) #1431
8ba07fe
ce-bo pushed a commit that referenced this issue Nov 10, 2020
@Dmttr @ce-bo
apply scale and transform for X and Y coordinates #1431
d5c4e13
ce-bo added a commit that referenced this issue Nov 10, 2020
@ce-bo
Fix scaling #1431
9894ee1 
Add some todos and notes #1431
ce-bo added a commit that referenced this issue Nov 10, 2020
@ce-bo
Adjust Changelog/How-to-guide #1431
4cdb301
ce-bo added a commit that referenced this issue Nov 10, 2020
@ce-bo
Fix scaling bug if margin is changed #1431
4313a08
ce-bo added a commit that referenced this issue Nov 11, 2020
@ce-bo
Fix scaling bug for multiple fixedFolder on the same level #1431
f32ea5d
ce-bo added a commit that referenced this issue Nov 11, 2020
@ce-bo
Add example json file to how-to-guide #1431
37b21bf
ce-bo added a commit that referenced this issue Nov 11, 2020
@ce-bo
Add and prepare unit test for fixed fodlers #1431
f792b1f
Dmttr added a commit that referenced this issue Nov 11, 2020
@Dmttr
complete unit test for fixed folders #1431
5a6045d
Dmttr added a commit that referenced this issue Nov 11, 2020
@Dmttr
modify fixed folders validation to work for sub fixed folders #1431
bcfbd24
Dmttr added a commit that referenced this issue Nov 11, 2020
@Dmttr
add fixed sub folders validation test #1431
9474904
@ce-bo ce-bo self-assigned this Nov 11, 2020
ce-bo added a commit that referenced this issue Nov 12, 2020
@ce-bo
Apply PR suggestions #1431
fb3491e
ce-bo added a commit that referenced this issue Nov 12, 2020
@ce-bo
Add formatter #1431
016771a
ce-bo added a commit that referenced this issue Nov 12, 2020
@ce-bo
Add a note #1431
9fcf711
RomanenkoVladimir added a commit that referenced this issue Nov 12, 2020
@Dmttr @ce-bo @RomanenkoVladimir
Feature/1431/fixed folder algorithm for sub folders (#1471)
15115ea 
* hasFixedFolders inpects the whole map #1431

* Revert "hasFixedFolders inpects the whole map #1431"

This reverts commit 7f1b0bf.

* recursion for buildSquarifiedTreeMaps (incomplete) #1431

* apply scale and transform for X and Y coordinates #1431

* Fix scaling #1431

Add some todos and notes #1431

* Adjust Changelog/How-to-guide #1431

* Fix scaling bug if margin is changed #1431

* Fix scaling bug for multiple fixedFolder on the same level #1431

* Add example json file to how-to-guide #1431

* Add and prepare unit test for fixed fodlers #1431

* complete unit test for fixed folders #1431

* modify fixed folders validation to work for sub fixed folders #1431

* add fixed sub folders validation test #1431

* Apply PR suggestions #1431

* Add formatter #1431

* Add a note #1431

Co-authored-by: Cedrik Bormann <cedrikbormann@gmail.com>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ce-bo ce-bo

@Dmttr Dmttr

Labels
feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1431/fixed folder algorithm for sub folders MaibornWolff/codecharta
3 participants
@BridgeAR @ce-bo @Dmttr