Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighted label while hovering over building #1529

Closed
Gaugi28 opened this issue Dec 1, 2020 · 3 comments · Fixed by #1586
Closed

Highlighted label while hovering over building #1529

Gaugi28 opened this issue Dec 1, 2020 · 3 comments · Fixed by #1586
Assignees
@RomanenkoVladimir
Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO

Comments

@Gaugi28
Copy link

Gaugi28 commented Dec 1, 2020

Feature request

Description

As a user, I want a highlighted label when I hover over the associated building so that I can see directly the name of the file.

Acceptance criteria

  • if the user hovers over a building, the label appears in the foreground and is highlighted
@ce-bo ce-bo added feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Dec 1, 2020
@BridgeAR BridgeAR added difficulty:low Solving this is likely not that difficult priority:medium Set by PO labels Dec 1, 2020
@RomanenkoVladimir
Copy link
Member

A question: In case of hovering a building with label? Or in case of hovering any building?
So if the building has no label but is hovered do we create a label for the duration of the hover event?

@BridgeAR
Copy link
Member

BridgeAR commented Dec 1, 2020

Good question. I personally would prefer the building to visualize the label during hovering as well, no matter if it's already visible or not.

But this specific issue was only about the hovering effect of the visible label:

Label hovered (highlights the label and building):
image

Building hovered (highlights the building only. This should be fixed to also highlight the label):
image

Not hovered. Nothing is highlighted.
image

@RomanenkoVladimir
Copy link
Member

TODO: we also need to take into account constant highlighting and maybe add a tint to the label for a selected node

RomanenkoVladimir added a commit that referenced this issue Dec 14, 2020
@RomanenkoVladimir
Refactor codeMapMouseEvent.ts, Highlight labels when hovering building …
28fa32e 
…#1529
RomanenkoVladimir added a commit that referenced this issue Dec 14, 2020
@RomanenkoVladimir
Add label for hovered node #1529
7f33f55
@RomanenkoVladimir RomanenkoVladimir mentioned this issue Dec 14, 2020
Merged
RomanenkoVladimir added a commit that referenced this issue Dec 16, 2020
@RomanenkoVladimir
Fix and Clean Up existing tests #1529
552ddf5
RomanenkoVladimir added a commit that referenced this issue Dec 16, 2020
@RomanenkoVladimir
Add tests for some functionality #1529
0264185
RomanenkoVladimir added a commit that referenced this issue Dec 17, 2020
@RomanenkoVladimir
Add tests for all not threeJS coupled functionality #1529
d15e785
RomanenkoVladimir added a commit that referenced this issue Dec 18, 2020
@RomanenkoVladimir
Applied review feedback, Fixed issue with height coefficent #1529
1d92f32
RomanenkoVladimir added a commit that referenced this issue Dec 18, 2020
@RomanenkoVladimir
Added intersection tests #1529
66e0a72
RomanenkoVladimir added a commit that referenced this issue Dec 20, 2020
@RomanenkoVladimir
Apply review feedback #1529
c45a1b3
ce-bo added a commit that referenced this issue Dec 21, 2020
@RomanenkoVladimir @ce-bo
Tech/refactor label interaction (#1586)
3bdbc78 
* Refactor codeMapMouseEvent.ts, Highlight labels when hovering building #1529

* Add label for hovered node #1529

* Fix and Clean Up existing tests #1529

* Add tests for some functionality #1529

* Add tests for all not threeJS coupled functionality #1529

* Update Changelog

* Applied review feedback, Fixed issue with height coefficent #1529

* Fix test

* Added intersection tests #1529

* Fix test

* Fix test

* Review feedback

* Apply review feedback #1529

Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Med-H pushed a commit that referenced this issue Jan 18, 2021
@RomanenkoVladimir @ce-bo @Med-H
Tech/refactor label interaction (#1586)
9840a51 
* Refactor codeMapMouseEvent.ts, Highlight labels when hovering building #1529

* Add label for hovered node #1529

* Fix and Clean Up existing tests #1529

* Add tests for some functionality #1529

* Add tests for all not threeJS coupled functionality #1529

* Update Changelog

* Applied review feedback, Fixed issue with height coefficent #1529

* Fix test

* Added intersection tests #1529

* Fix test

* Fix test

* Review feedback

* Apply review feedback #1529

Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanenkoVladimir RomanenkoVladimir

Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tech/refactor label interaction MaibornWolff/codecharta
4 participants
@BridgeAR @Gaugi28 @RomanenkoVladimir @ce-bo