Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge of the flattened and excluded buildings in search-panel-mode-selector #1543

Closed
Gaugi28 opened this issue Dec 3, 2020 · 0 comments · Fixed by #1608
Closed

Merge of the flattened and excluded buildings in search-panel-mode-selector #1543

Gaugi28 opened this issue Dec 3, 2020 · 0 comments · Fixed by #1608
Assignees
@JaiJoPa
Labels
difficulty:low Solving this is likely not that difficult feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@Gaugi28
Copy link

Gaugi28 commented Dec 3, 2020 •
edited

Feature request

Description

As user, I want one icon for flattened and excluded buildings together so that so that I can see at one glance which buildings are hidden.

Acceptance criteria

  • the button for excluded buildings is deleted
  • if the user clicks on the button with the eye slash the user sees the merged blacklist with the excluded and flattened buildings.
  • tooltip description is changed to: "Excluded and flattened buildings"
  • changed icon in the the context menu: instead of the eye-slash icon there is a new icon as shown in the image.

Only one Icon for both functions:
image

Context menu:
image

New Icon:
cubes_24px

Open questions

Do the developers need a svg file for the new icon?
@RomanenkoVladimir RomanenkoVladimir added difficulty:low Solving this is likely not that difficult feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Dec 3, 2020
@BridgeAR BridgeAR added the priority:high Set by PO label Dec 6, 2020
@JaiJoPa JaiJoPa self-assigned this Dec 15, 2020
JaiJoPa added a commit that referenced this issue Dec 17, 2020
@JaiJoPa
Change icon for flatten in nodeContextMenu #1543
0b12bff
JaiJoPa added a commit that referenced this issue Dec 17, 2020
@JaiJoPa
Add flatten png #1543
0c8b433
JaiJoPa added a commit that referenced this issue Dec 17, 2020
@JaiJoPa
merge flatten and exclude in searchpanel #1543
4eab631
JaiJoPa added a commit that referenced this issue Dec 17, 2020
@JaiJoPa
Add tooltip #1543
baf16a1
JaiJoPa added a commit that referenced this issue Dec 17, 2020
@JaiJoPa
Update changelog #1543
48c2277
JaiJoPa added a commit that referenced this issue Dec 18, 2020
@JaiJoPa
Change icon for flatten in matchingFilesCounter #1543
ad1444a
@JaiJoPa JaiJoPa mentioned this issue Dec 18, 2020
Merged
ce-bo added a commit that referenced this issue Dec 21, 2020
@ce-bo
Apply code formating #1543
b5d082a
ce-bo added a commit that referenced this issue Dec 21, 2020
@ce-bo
Apply code formating #1543
481f7f9
ce-bo added a commit that referenced this issue Dec 21, 2020
@JaiJoPa @Med-H
@BridgeAR @ce-bo
Feature/1543/merge flattened excluded in search panel (#1608)
d31312f 
* Change icon for flatten in nodeContextMenu #1543

* Add flatten png #1543

* merge flatten and exclude in searchpanel #1543

* Add tooltip #1543

* Update changelog #1543

* Change icon for flatten in matchingFilesCounter #1543

* Update CHANGELOG.md

* Update visualization/app/codeCharta/ui/searchPanelModeSelector/searchPanelModeSelector.component.html

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Apply code formating #1543

Co-authored-by: mehdi hambli <74670211+Med-H@users.noreply.github.com>
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Co-authored-by: Cedrik Bormann <cedrikbormann@gmail.com>
ce-bo added a commit that referenced this issue Dec 23, 2020
@Med-H @ce-bo
Feature/905/street map layout (#1585)
ff46492 
* initial street layout introduction

* may be a  fix for e2e filechooser test

* street layout flattening fix, filechooser e2e fix, global setting dialog layout improvement, code refactoring

* fixed TMStreet layout

* added max treemap files

* fixing linting, added remark about e2e falky test fix, added streetlayout todo

* edited changelog

* fixes after @BridgeAR review

* updated changelog

* Apply code formating #1543

* Update visualization/app/codeCharta/ui/maxTreeMapFiles/maxTreeMapFiles.component.ts

* Update visualization/app/codeCharta/util/algorithm/streetLayout/horizontalStreet.ts

* Update visualization/app/codeCharta/streetLayoutTodo.md

* Update visualization/app/codeCharta/util/algorithm/streetLayout/streetViewHelper.ts

* Update visualization/app/codeCharta/util/algorithm/streetLayout/verticalStreet.ts

* Update visualization/app/codeCharta/util/algorithm/treeMapLayout/treeMapHelper.ts

* Improve identation #905

* Merge main, Fix label position conflicts #905

* Fix scaling bug and improve performance

* Fix label positioning bug on mouse move, Apply minor refactorings.

* Add regression tests for label scaling/positioning bugs

* Fix temporary label bug: reset on map move/turn

Co-authored-by: Cedrik Bormann <cedrikbormann@gmail.com>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
shaman-apprentice pushed a commit that referenced this issue Jan 11, 2021
@Med-H @ce-bo
Fix/1632/reset street layout global config (#1633)
14df6a2 
* initial street layout introduction

* may be a  fix for e2e filechooser test

* street layout flattening fix, filechooser e2e fix, global setting dialog layout improvement, code refactoring

* fixed TMStreet layout

* added max treemap files

* fixing linting, added remark about e2e falky test fix, added streetlayout todo

* edited changelog

* fixes after @BridgeAR review

* updated changelog

* Apply code formating #1543

* Update visualization/app/codeCharta/ui/maxTreeMapFiles/maxTreeMapFiles.component.ts

* Update visualization/app/codeCharta/util/algorithm/streetLayout/horizontalStreet.ts

* Update visualization/app/codeCharta/streetLayoutTodo.md

* Update visualization/app/codeCharta/util/algorithm/streetLayout/streetViewHelper.ts

* Update visualization/app/codeCharta/util/algorithm/streetLayout/verticalStreet.ts

* Update visualization/app/codeCharta/util/algorithm/treeMapLayout/treeMapHelper.ts

* Improve identation #905

* Merge main, Fix label position conflicts #905

* Fix scaling bug and improve performance

* adding layout reset behavior

* Fix hard coded year in unit test

* fix #1624

* fix #1624

* fix test

* fix test

* fix test

* fix flaky test

* fix flaky test

* fix flaky Integration test

* added agenda regression tests for 53 week years

* Update CalendarWeekTest.kt

* Update CalendarWeekTest.kt

* Update CalendarWeekTest.kt

* possible fix for flaky test timeout

* added some comments & updated changelog

* remove trailing spaces

Co-authored-by: Cedrik Bormann <cedrikbormann@gmail.com>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Co-authored-by: Torsten Knauf <Torsten.Knauf@maibornwolff.de>
Med-H pushed a commit that referenced this issue Jan 18, 2021
@ce-bo @Med-H
Apply code formating #1543
0878099
Med-H added a commit that referenced this issue Jan 18, 2021
@JaiJoPa @Med-H
@BridgeAR @ce-bo
Feature/1543/merge flattened excluded in search panel (#1608)
b90f443 
* Change icon for flatten in nodeContextMenu #1543

* Add flatten png #1543

* merge flatten and exclude in searchpanel #1543

* Add tooltip #1543

* Update changelog #1543

* Change icon for flatten in matchingFilesCounter #1543

* Update CHANGELOG.md

* Update visualization/app/codeCharta/ui/searchPanelModeSelector/searchPanelModeSelector.component.html

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* Apply code formating #1543

Co-authored-by: mehdi hambli <74670211+Med-H@users.noreply.github.com>
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Co-authored-by: Cedrik Bormann <cedrikbormann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaiJoPa JaiJoPa

Labels
difficulty:low Solving this is likely not that difficult feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1543/merge flattened excluded in search panel MaibornWolff/codecharta
4 participants
@BridgeAR @Gaugi28 @RomanenkoVladimir @JaiJoPa