Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path to node context menu #1667

Closed
shaman-apprentice opened this issue Jan 13, 2021 · 0 comments · Fixed by #1933
Closed

Add path to node context menu #1667

shaman-apprentice opened this issue Jan 13, 2021 · 0 comments · Fixed by #1933
Assignees
@Shivan-997
Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience

Comments

@shaman-apprentice
Copy link
Contributor

Feature request

Description

As a user I want to know the node, for which the current open node context menu is open. Currently only node is displayed.

image

Acceptance criteria

  • Path of node is added to the node context menu

Open questions

  • The current present static "NODE" label can probably be removed, as it takes up space but provides no useful information. On the contrary the label is confusing, as it could also be "FLOOR", or "PACKAGES", or "FOLDER", ...
  • How to deal with long paths. Should we shorten them or just make the popup very broad?
@shaman-apprentice shaman-apprentice added the UX / UI Everything related to design and user experience label Jan 13, 2021
@BridgeAR BridgeAR added difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO labels Feb 26, 2021
@Shivan-997 Shivan-997 self-assigned this Apr 19, 2021
Shivan-997 pushed a commit that referenced this issue Apr 19, 2021
add path to node context menu #1667
b4c8be7
@Shivan-997 Shivan-997 mentioned this issue Apr 19, 2021
Merged
Shivan-997 pushed a commit that referenced this issue Apr 19, 2021
adjust changes for suggestion and add test for onShowNodeContextMenu #…
69d83ae 
…1667
Shivan-997 pushed a commit that referenced this issue Apr 19, 2021
run prittier #1667
3a74ac6
NearW added a commit that referenced this issue Apr 19, 2021
@Shivan-997 @NearW
Feature/1667/add path to node context menu (#1933)
8b1ba3e 
* add path to node context menu #1667

* remove unnecessary span tag and merge main

* adjust changes for suggestion and add test for onShowNodeContextMenu #1667

* run prittier #1667

Co-authored-by: Shivan Oskan <shivan.oskan@maibornwolff.de>
Co-authored-by: Ben Willenbring <ben-willenbring@t-online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shivan-997 Shivan-997

Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1667/add path to node context menu MaibornWolff/codecharta
3 participants
@shaman-apprentice @BridgeAR @Shivan-997