Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels and lines are not connected #1716

Closed
Med-H opened this issue Feb 2, 2021 · 1 comment · Fixed by #1948
Closed

Labels and lines are not connected #1716

Med-H opened this issue Feb 2, 2021 · 1 comment · Fixed by #1948
Assignees
@RomanenkoVladimir
Labels
bug Only issues that describe bugs. difficulty:medium The difficulty to solve this is not super complex but not easy either javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
CC
Milestone
bug-hunt

Comments

@Med-H
Copy link
Contributor

Med-H commented Feb 2, 2021

Bug

Labels and lines are not connected

Expected Behavior

GIVEN

A ccjson file ( ex the AM sonar one )

WHEN

Zooming in the map and hovering on the buildings.

THEN

The labels and lines are connected.

Actual Behavior

image

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.67.0
  • OS: Windows
  • Browser: Chrome
@Med-H Med-H added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. labels Feb 2, 2021
@Med-H Med-H added this to To do in CC via automation Feb 2, 2021
@RomanenkoVladimir
Copy link
Member

Here we need to get the new center point of the label after popup(threeJS can do that for us) and pass it to the line to change its draw height, maybe account for offsets. Should be easy to fix.

@RomanenkoVladimir RomanenkoVladimir added this to the bug-hunt milestone Feb 5, 2021
@RomanenkoVladimir RomanenkoVladimir added the difficulty:low Solving this is likely not that difficult label Feb 5, 2021
@BridgeAR BridgeAR added the priority:medium Set by PO label Feb 19, 2021
@RomanenkoVladimir RomanenkoVladimir self-assigned this Mar 16, 2021
@RomanenkoVladimir RomanenkoVladimir added difficulty:medium The difficulty to solve this is not super complex but not easy either and removed difficulty:low Solving this is likely not that difficult labels Mar 22, 2021
RomanenkoVladimir added a commit that referenced this issue Apr 21, 2021
@RomanenkoVladimir
Fix issue, update line position according to view angle #1716
631f238
RomanenkoVladimir added a commit that referenced this issue Apr 22, 2021
@RomanenkoVladimir
Update tests for new label-line behaviour #1716
cdcf84d
RomanenkoVladimir added a commit that referenced this issue Apr 22, 2021
@RomanenkoVladimir
Add tests, Remove dead code, Some refactoring #1716
5d06c7c
@RomanenkoVladimir RomanenkoVladimir mentioned this issue Apr 22, 2021
Merged
RomanenkoVladimir added a commit that referenced this issue Apr 22, 2021
@RomanenkoVladimir
Fix line interaction #1716
b293c1d
RomanenkoVladimir added a commit that referenced this issue Apr 27, 2021
@RomanenkoVladimir
Apply REview Suggestions #1716
1d0c62c
CC automation moved this from To do to Done Apr 27, 2021
RomanenkoVladimir added a commit that referenced this issue Apr 27, 2021
@RomanenkoVladimir
Fix/1716/labels not connected with lines (#1948)
d1fa1c8 
* Fix issue, update line position according to view angle #1716

* Refactoring

* Update tests for new label-line behaviour #1716

* Add tests, Remove dead code, Some refactoring #1716

* Update Changelog

* Run prettier

* Fix bug

* Fix line interaction #1716

* Apply Changes request

* Apply REview Suggestions #1716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanenkoVladimir RomanenkoVladimir

Labels
bug Only issues that describe bugs. difficulty:medium The difficulty to solve this is not super complex but not easy either javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
No open projects
CC
  
Done
Milestone
bug-hunt
Development

Successfully merging a pull request may close this issue.

Fix/1716/labels not connected with lines MaibornWolff/codecharta
3 participants
@BridgeAR @RomanenkoVladimir @Med-H