Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes with Three.js #1877

Closed
RomanenkoVladimir opened this issue Mar 17, 2021 · 0 comments · Fixed by #1899
Closed

Breaking changes with Three.js #1877

RomanenkoVladimir opened this issue Mar 17, 2021 · 0 comments · Fixed by #1899
Assignees
@RomanenkoVladimir
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO tech For technical stories without user impact (=refactoring stories).

Comments

@RomanenkoVladimir
Copy link
Member

RomanenkoVladimir commented Mar 17, 2021 •
edited

Bug

The project is not compiling correctly due to recent breaking changes to three.js, removing "Geometry" from their project and asking everyone to migrate to "BufferGeometry".

This affects codeMap.label.service.ts directly, as it uses Geometry() for lines and will result in a compilation error.

Expected Behavior

The newest version of three.js WHEN compiling the project THEN it compiles without warnings and works correctly.

Actual Behavior

It crashes/ produces inconsistent behaviour.

Screenshots

Steps to Reproduce the Problem

  1. Pull main
  2. run 'npm i'
  3. run 'npm audit fix'
  4. the project compliation fails with a warning and a console error in the browser

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: any
  • OS: any
  • Browser: any
@RomanenkoVladimir RomanenkoVladimir added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. tech For technical stories without user impact (=refactoring stories). labels Mar 17, 2021
@BridgeAR BridgeAR added the priority:high Set by PO label Mar 19, 2021
@RomanenkoVladimir RomanenkoVladimir mentioned this issue Mar 26, 2021
Merged
RomanenkoVladimir added a commit that referenced this issue Apr 15, 2021
@RomanenkoVladimir
Update Tests #1877
f4c8634
BridgeAR pushed a commit that referenced this issue Apr 23, 2021
@RomanenkoVladimir @BridgeAR
Update Tests #1877
fa338fe
RomanenkoVladimir added a commit that referenced this issue Apr 30, 2021
@RomanenkoVladimir
Migrate line Geometry implementation to r127 #1877
a933678
BridgeAR pushed a commit that referenced this issue Apr 30, 2021
@RomanenkoVladimir
Tech/1877/update three js (#1899)
88af948 
* Update three.js 0.124 to 0.126.1

* Update Changelog

* EffectComposer location change

* fix: add three types to the package.json

Three.js moved their types to definitely typed. This adds the
required module.

* refactor: change async code to sync code

The API changed and should be handled accordingly.

* fix: add a debounce time to improve e2e test stability

* chore: fix BufferGeometry building highlight

* Migrate line Geometry implementation to r127 #1877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanenkoVladimir RomanenkoVladimir

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO tech For technical stories without user impact (=refactoring stories).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tech/1877/update three js MaibornWolff/codecharta
2 participants
@BridgeAR @RomanenkoVladimir