Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion Error in TreeMapStreet Layout #1932

Open
Jacob-Kirimi opened this issue Apr 18, 2021 · 3 comments
Open

Exclusion Error in TreeMapStreet Layout #1932

Jacob-Kirimi opened this issue Apr 18, 2021 · 3 comments
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs. priority:medium Set by PO

Comments

@Jacob-Kirimi
Copy link
Contributor

Jacob-Kirimi commented Apr 18, 2021

Bug

The exclusion of some buildings results to the exclusion of other smaller buldings in the folder they are in

Expected Behavior

The exclusion of a building should only make the choosen building to disappear. (maybe the parent folder to maintain its size)

Actual Behavior

The exclusion of a building may result to smaller buildings in the same folder to disappear. and the containing folder to become
smaller

Screenshots

bug

Steps to Reproduce the Problem

  1. Change to treeMapStreet Layout
  2. Exclude the otherSmallLeaf.ts file (Both files in the Folder dissappear and the folder size becomes smaller )
  3. Exclude the unseen building in the map tree level menu (the folder size resumes its original size)
@Jacob-Kirimi Jacob-Kirimi added the bug Only issues that describe bugs. label Apr 18, 2021
@BridgeAR
Copy link
Member

AFAIK this is an issue with the margins. Due to the rerendering, the building now has a width that is too tiny and it's not rendered anymore. I mark this as blocked for now.

@BridgeAR BridgeAR added the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Apr 23, 2021
@BridgeAR BridgeAR added priority:high Set by PO and removed blocked The issue or feature is blocked on another issue or PR that has to be resolved first labels Nov 24, 2022
@BridgeAR
Copy link
Member

I removed the blocked label due to #3077 landing. @RomanenkoVladimir or anyone else, please check if this is already fixed or not due to that change! :-)

I added the high priority label @ce-bo. I hope that's fine? I would at least like this to be verified soon.

@ce-bo
Copy link
Collaborator

ce-bo commented Nov 24, 2022

@BridgeAR This is accepted. Let's verify it.

@ce-bo ce-bo added the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Mar 2, 2023
@ChristianHuehn ChristianHuehn added priority:medium Set by PO and removed priority:high Set by PO labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs. priority:medium Set by PO
Projects
None yet
Development

No branches or pull requests

4 participants