Bug/3044/margin renders some buildings missing

[RomanenkoVladimir]

Modify area calculation to prevent disappearing buildings

Please read the CONTRIBUTING.md before opening a PR.

closes: #3044, #3096, #3081

Description

• Change algorithm to visualize buildings that are getting removed by margin
• Make margin scale with map size
• Change floor label calculation to prevent floor labels that are "sandwitched" between bigger folders from rendering without buildings
• add tests to explain new behaviour
• maps are now quite bigger to assure that all buildings fit
• sizes of folder areas should now more closely match each other when they are the same size

Screenshots or gifs

[RomanenkoVladimir]

However, I am still unhappy with the floor label solution and what be glad for any feedback or the potential to discuss it

[RomanenkoVladimir]

I would appreciate your feedback, now that maps are again squares and big maps are scaled down a bit

[RomanenkoVladimir]

Also for the changed floor label criteria and overall applicability for presentations

[ce-bo]

It is looking good to me. We should check one last thing.
With experimental features = on, the anon.cc.json is crashing with the following errors:

[MW-Friedrich]

LGTM!
Thanks a lot for writing some documentation too, that helped a lot 👍

[sonarcloud]

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

96.6% Coverage
0.0% Duplication

[BridgeAR]

Dear team, I would like to celebrate fixing this somehow. Do you have a suggestion what you would like to do or would you rather not do anything special?

[ce-bo]

It is looking good to me. We should check one last thing. With experimental features = on, the anon.cc.json is crashing with the following errors:

@MW-Friedrich Did you have a look on that?

[MW-Friedrich]

It is looking good to me. We should check one last thing. With experimental features = on, the anon.cc.json is crashing with the following errors:

@MW-Friedrich Did you have a look on that?

Yes, I did, and I unfortunately couldn't reproduce the error. The anon.cc.json is the file that is loaded when starting CodeCarta in development mode (npm run dev), right?

[ce-bo]

Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.

[MW-Friedrich]

Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.

I found and fixed the error together with @BenediktMehl in another issue, since we found out that the error had nothing to do with the margins. Good catch though!

[ce-bo]

Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.

I found and fixed the error together with @BenediktMehl in another issue, since we found out that the error had nothing to do with the margins. Good catch though!

Thank you. This was fixed in #3144