Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend background #2422

Closed
jannikr opened this issue Oct 4, 2021 · 1 comment · Fixed by #2510
Closed

Legend background #2422

jannikr opened this issue Oct 4, 2021 · 1 comment · Fixed by #2510
Assignees
@Christian-Eberhard
Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP

Comments

@jannikr
Copy link
Contributor

jannikr commented Oct 4, 2021 •
edited by BridgeAR

Bug

Expected Behavior

GIVEN loaded codecharta.cc.json sample map

WHEN opening legend panel

THEN the background should be the same color as the regular background in order to hide distracting informations behind the legend panel

Actual Behavior

THEN transparent background is distracted by the informations behind the legend panel

Screenshots

legend_panel_background

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.80.0
  • OS: Mac
  • Browser: Chrome
@jannikr jannikr added the bug Only issues that describe bugs. label Oct 4, 2021
@jannikr
Copy link
Contributor Author

jannikr commented Oct 5, 2021

Please pay attention to this issue. Here we changed from a white background to a transparent background: Legend improvements

@ce-bo ce-bo added javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Oct 7, 2021
@BridgeAR BridgeAR added the priority:urgent Should be addressed ASAP label Nov 8, 2021
@Christian-Eberhard Christian-Eberhard self-assigned this Nov 16, 2021
Christian-Eberhard pushed a commit that referenced this issue Nov 16, 2021
Add border and background to legend panel.
43c023d 
#2422
@Christian-Eberhard Christian-Eberhard mentioned this issue Nov 16, 2021
Merged
Christian-Eberhard pushed a commit that referenced this issue Nov 16, 2021
Add pr url to changelog
99cf7ee 
#2422
jannikr pushed a commit that referenced this issue Nov 16, 2021
@Christian-Eberhard @Shivan-997
Add border and background to legend panel. (#2510)
6f1e00f 
* Add border and background to legend panel.

#2422

* Add pr url to changelog

#2422

Co-authored-by: ChristianE <christian.eberhard@maibornwolff.de>
Co-authored-by: Shivan-997 <57844849+Shivan-997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christian-Eberhard Christian-Eberhard

Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:urgent Should be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add border and background to legend panel. MaibornWolff/codecharta
4 participants
@BridgeAR @ce-bo @jannikr @Christian-Eberhard