Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute Sidebar: Change to Median no longer possible in Secondary Metrics #2630

Closed
Hall-Ma opened this issue Jan 28, 2022 · 1 comment · Fixed by #2746
Closed

Attribute Sidebar: Change to Median no longer possible in Secondary Metrics #2630

Hall-Ma opened this issue Jan 28, 2022 · 1 comment · Fixed by #2746
Assignees
@shaman-apprentice
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Jan 28, 2022 •
edited

Bug

Expected Behavior

When attibute sidebar is open then I can change from Sum to Median in Secondary Metrics list.

Actual Behavior

When attibute sidebar is open I only can change global aggregation to Median in Primary Metrics. In Secondary Metrics I can choose Median but nothing is changed including the button.

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.88.0
  • OS: Windows
  • Browser: Chrome
@Hall-Ma Hall-Ma added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jan 28, 2022
@BridgeAR BridgeAR added the priority:high Set by PO label Feb 4, 2022
@shaman-apprentice shaman-apprentice self-assigned this Mar 21, 2022
@shaman-apprentice
Copy link
Contributor

During fixing I noticed, that edge metrics are not taken into account by secondary Metrics. Is that on purpose? Should We create a feature / bug request for that? (@BridgeAR )

shaman-apprentice pushed a commit that referenced this issue Mar 21, 2022
fix: handling of attribute type
499a1e0 
- set initial primary edges metric correctly
- dispatch secondary metric type correctly

ref #2731
ref #2630
@shaman-apprentice shaman-apprentice mentioned this issue Mar 21, 2022
Merged
shaman-apprentice pushed a commit that referenced this issue Mar 22, 2022
refactor: simplify extraction of attribute type
010bddd 
ref #2731
ref #2630
shaman-apprentice pushed a commit that referenced this issue Mar 22, 2022
test: add test
3e6e7a7 
ref #2731
ref #2630
shaman-apprentice pushed a commit that referenced this issue Mar 22, 2022
test: add test
7f78a73 
ref #2731
ref #2630
shaman-apprentice pushed a commit that referenced this issue Mar 23, 2022
docs: add changelog entry
50f3378 
ref #2731
ref #2630
shaman-apprentice added a commit that referenced this issue Mar 23, 2022
@shaman-apprentice
fix: handling of attribute type (#2746)
946f2de 
* fix:  handling of attribute type

- set initial primary edges metric correctly
- dispatch secondary metric type correctly

ref #2731
ref #2630

* refactor: simplify extraction of attribute type

ref #2731
ref #2630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaman-apprentice shaman-apprentice

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handling of attribute type MaibornWolff/codecharta
3 participants
@shaman-apprentice @BridgeAR @Hall-Ma