Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading gif is always visible in ribbon bar #2680

Closed
Hall-Ma opened this issue Feb 22, 2022 · 1 comment · Fixed by #2683
Closed

Loading gif is always visible in ribbon bar #2680

Hall-Ma opened this issue Feb 22, 2022 · 1 comment · Fixed by #2683
Assignees
@shaman-apprentice
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.

Comments

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Feb 22, 2022

Bug

Expected Behavior

When open CodeCharta, the loading gif is only visible while a file is loaded.

Actual Behavior

When starting CodeCharta the loading gif is always visible.

Screenshots

image

Steps to Reproduce the Problem

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.91.0
  • OS: Windows
  • Browser: Chrome
@Hall-Ma Hall-Ma added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Feb 22, 2022
@shaman-apprentice
Copy link
Contributor

##First analyse:

With 4ad684e the following scenario stopped working / before this commit it worked with the local dev app:

  1. npm run dev
  2. Load latest version of released CodeCharta demo app (v1.91.0)
  3. Open file selections and select sample2.cc.json

Loading Gif stays AND sample2.cc.json isn't displayed in the map.

To be further analysed:

Is the cause for this the same bug as in the demo app or is this another bug?

shaman-apprentice added a commit that referenced this issue Feb 23, 2022
@shaman-apprentice
fix: loading of files without edge metric never finished
e4dd4fd 
ref #2680
@shaman-apprentice shaman-apprentice mentioned this issue Feb 23, 2022
Merged
Hall-Ma pushed a commit that referenced this issue Feb 25, 2022
@shaman-apprentice
fix: loading of files without edge metric never finished (#2683)
3a61599 
ref #2680
Hall-Ma added a commit that referenced this issue Feb 25, 2022
@Hall-Ma
Adjust CHANGELOG.md
36f69c6 
#2680
Hall-Ma added a commit that referenced this issue Feb 25, 2022
@Hall-Ma
Rearrange changelog entry from PR #2680
05ab360
@Hall-Ma Hall-Ma mentioned this issue Feb 25, 2022
Merged
Hall-Ma added a commit that referenced this issue Feb 25, 2022
@Hall-Ma
Rearrange changelog entry from PR #2680 (#2685)
9d5b9d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaman-apprentice shaman-apprentice

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: loading of files without edge metric never finished MaibornWolff/codecharta
2 participants
@shaman-apprentice @Hall-Ma