Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom view of the sample map after upload is not possible in the demo #2762

Closed
Hall-Ma opened this issue Mar 30, 2022 · 0 comments · Fixed by #2769
Closed

Using custom view of the sample map after upload is not possible in the demo #2762

Hall-Ma opened this issue Mar 30, 2022 · 0 comments · Fixed by #2769
Assignees
@Hall-Ma
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.

Comments

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Mar 30, 2022

Bug

Expected Behavior

Sample maps (codecharta.cc.json, codecharta_analysis.cc.json)

When custom views are created, saved, and downloaded from the preselected sample file, they should be clickable again after uploading.

Actual Behavior

When custom views are created, saved, and downloaded from the preselected sample file, they are not clickable again after uploading.

Note:

This only happens when you use the preselected map. (After each reselection of the files, they will be set to multiple mode.)
For more information see #2761 (comment)

Steps to Reproduce the Problem

  1. Save, and download a new custom view from our sample maps (chose the map that is already selected and don't select it again)
  2. Delete custom views in the demo
  3. Upload saved custom view (it won't be clickable now)

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.95.0
  • OS: Windows
  • Browser: Chrome
@Hall-Ma Hall-Ma added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. difficulty:low Solving this is likely not that difficult labels Mar 30, 2022
@Hall-Ma Hall-Ma changed the title Using the custom view of the sample map after upload is not possible in the demo Using custom view of the sample map after upload is not possible in the demo Mar 30, 2022
@Hall-Ma Hall-Ma self-assigned this Apr 1, 2022
Hall-Ma added a commit that referenced this issue Apr 1, 2022
@Hall-Ma
Set loaded files via url to multiple mode by default (when delta mode…
30b64a9 
… is not selected)

#2762
@Hall-Ma Hall-Ma mentioned this issue Apr 1, 2022
Merged
Hall-Ma added a commit that referenced this issue Apr 1, 2022
@Hall-Ma
Add changelog entry
3bd6300 
#2762
Hall-Ma added a commit that referenced this issue Apr 1, 2022
@Hall-Ma
Adjust e2e test (both files are loaded and set to multiple mode)
6e862fd 
#2762
Hall-Ma added a commit that referenced this issue Apr 8, 2022
@Hall-Ma
Add tests to cover the file setting mode correctly
1d1bb67 
#2762
Hall-Ma added a commit that referenced this issue Apr 8, 2022
@Hall-Ma
Add tests to cover the file setting mode correctly (including edge ca…
4242247 
…ses)

#2762
Hall-Ma added a commit that referenced this issue Apr 8, 2022
@Hall-Ma
Fix/2762/Set loaded files via url to multiple mode by default (#2769)
afc2204 
* Set loaded files via url to multiple mode by default (when delta mode is not selected)
#2762

* Add changelog entry
#2762

* Adjust e2e test (both files are loaded and set to multiple mode)
#2762

* Add tests to cover the file setting mode correctly
#2762

* Add tests to cover the file setting mode correctly (including edge cases)
#2762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hall-Ma Hall-Ma

Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/2762/Set loaded files via url to multiple mode by default MaibornWolff/codecharta
1 participant
@Hall-Ma